feat: view flow screenshots and plan (issue #226)#304
Open
Kosinkadink wants to merge 3 commits into
Open
Conversation
Phase 1 of the view-flow documentation effort: - Add Playwright e2e test that captures screenshots of all 6 tab views and 4 modals (Dashboard, Installs, Running, Models, Media, Settings, New Install, Track Existing, Load Snapshot, Quick Install) - Add docs/view-flow-plan.md with the full 4-phase plan - Screenshots saved to docs/screenshots/ for use by the flow-graph generator (Phase 2) and Figma plugin (Phase 3) Amp-Thread-ID: https://ampcode.com/threads/T-019d2342-103c-71fa-a493-9e945e234649 Co-authored-by: Amp <amp@ampcode.com>
- Replace all waitForTimeout calls with proper Playwright waiters - Fail on missing modal buttons instead of silently skipping - Split monolithic test into individual test() blocks - Remove committed PNGs and gitignore docs/screenshots/ - Clarify Phase 1 screenshot count in plan doc - Use fileURLToPath instead of __dirname for ESM compat Amp-Thread-ID: https://ampcode.com/threads/T-019d23e9-30cf-755f-8ed3-a7038aafe01e Co-authored-by: Amp <amp@ampcode.com>
Add scripts/generate-view-flow.mjs that parses App.vue to extract the view→modal navigation graph and outputs a Mermaid diagram to docs/view-flow.md. - Extracts @event bindings from App.vue template - Resolves handlers to target views/modals - Parses emit() calls in child views for cross-references - Generates Mermaid flowchart with 14 nodes and 30 edges - Adds pnpm run generate:view-flow convenience script Amp-Thread-ID: https://ampcode.com/threads/T-019d23e9-30cf-755f-8ed3-a7038aafe01e Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 1 of View/Modal Flow Documentation (#226)
Adds automated screenshot capture for all major views and modals in the launcher UI, plus a plan document for the full 4-phase effort.
What's included
Playwright e2e test (
e2e/view-flow-screenshots.spec.ts):docs/screenshots/Plan document (
docs/view-flow-plan.md):Notes