feat: manage ComfyUI-Manager security level from Desktop settings#1041
Open
Kosinkadink wants to merge 1 commit into
Open
feat: manage ComfyUI-Manager security level from Desktop settings#1041Kosinkadink wants to merge 1 commit into
Kosinkadink wants to merge 1 commit into
Conversation
ComfyUI-Manager has no runtime API to change its security_level; it reads it once from config.ini at startup. Without a Desktop-side control, users cannot relax/tighten which node packs may be installed (e.g. when ComfyUI is exposed with --listen), and the restriction is invisible in the UI. - Add a persistent managerSecurityLevel setting (strong/normal/normal-/weak) - Expose it as a select in the Advanced settings section - Reconcile config.ini before each local launch: write security_level on fresh installs and update it in place on existing configs, preserving other keys; skip when a legacy Manager config exists - Generalize ensureManagerMirrorConfig into ensureManagerConfig - Add en/zh translations Amp-Thread-ID: https://ampcode.com/threads/T-019eafaf-ac38-734b-8fa1-1422ed378e78 Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gives Desktop a UI control for ComfyUI-Manager's
security_level, addressing part of #1037.ComfyUI-Manager (v4) has no runtime API to change
security_level- it reads the value once fromconfig.iniat startup. As a result there is no way to relax or tighten which node packs may be installed (for example, when ComfyUI is exposed to the network with--listen, some installs are blocked for security), and the restriction is invisible to the user. Since Manager won't own this control, Desktop does.Changes
managerSecurityLevelsetting (strong/normal/normal-/weak).--listenimplications.config.inibefore each local launch:security_level(plus the China-mirror keys when opted in),security_levelin place while preserving all other keys,ensureManagerMirrorConfigintoensureManagerConfig.Companion PR
The offline-loading and security-message UX fixes from #1037 are handled in ComfyUI_frontend on branch
fix/manager-offline-loading-and-security-msg.Testing
pnpm typecheck/pnpm lintpass (run via pre-commit).pnpm test src/main/lib/managerConfig.test.ts- 15 tests pass (fresh/update/legacy behavior).Part of #1037