* support copying tags

[jbostoen]

Tested on iTop 2.7; but not on iTop 3 (I think it will work though).

I added a similar hack to the existing ones to support tags.

Basically the main issue is that while you attempt to copy an object, the "orig_value" correctly gets set. In the GUI, it means tags are visible when creating a copy of an object (before confirmation). However, the elements are therefore not present in the "added" part. Resulting in the lack of tags when objects are created.

This implementation also allows adding/removing tags during the process (before clicking [Create]).

Basically right before submission, the value of the attribute gets rewritten:

• from the original attribute values, all the elements are kept which have not been removed by the user
• a combination of the above + tags added manually by the user is created
• orig_value and removed are both cleared
• added becomes the result of above

[Molkobain]

Hello Jeffrey,

Thanks for the PR but the fix is incorrect, it should not be done using a JS hack. The right place for this to work would be in iTopObjectCopier::CopyAttribute().

Do you feel like reworking the PR or should I close it?

[jbostoen]

Hello Jeffrey,

Thanks for the PR but the fix is incorrect, it should be done using a JS hack. The right place for this to work would be in iTopObjectCopier::CopyAttribute().

Do you feel like reworking the PR or should I close it?

Do you mean "without" or not with a JS hack?

Been using it myself for quite a while now.

I could make a different version, if it would be considered?

[Molkobain]

I meant "without" indeed, thanks.
A different version would definitively be considered if it uses the right approach. :)

[Hipska]

Hi @jbostoen can you check if a39625c resolves this issue?