Skip to content

N°9482 - Preserve login_mode in the SESSION even when not passed by HTTP #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
odain-cbd wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

N°9482 - Preserve login_mode in the SESSION even when not passed by HTTP #874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91593ec
N°9482 - Preserve login_mode in the SESSION even when not passed by HTTP
odain-cbd Apr 7, 2026
d0b5ecc
N°9482 - add tests
odain-cbd Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions application/logindefault.class.inc.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ protected function OnStart(&$iErrorCode)
if ($index !== false) {
// Force login mode
Session::Set('login_mode', $sProposedLoginMode);
} else {
Session::Unset('login_mode');
}
return LoginWebPage::LOGIN_FSM_CONTINUE;
}
Expand Down
69 changes: 69 additions & 0 deletions tests/php-unit-tests/unitary-tests/application/LoginDefaultBeforeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
<?php

use Combodo\iTop\Application\Helper\Session;
use Combodo\iTop\Test\UnitTest\ItopDataTestCase;

/**
* @runClassInSeparateProcess Required because PHPUnit outputs something earlier, thus causing the headers to be sent
*/
class LoginDefaultBeforeTest extends ItopDataTestCase
{
protected function setUp(): void
{
parent::setUp();
Session::$bAllowCLI = true;
Session::Start();
$_REQUEST = [];
$this->RequireOnceItopFile('application/logindefault.class.inc.php');
}

protected function tearDown(): void
{
parent::tearDown();
Session::$bAllowCLI = false;
}

public function testOnStart_NoLoginModeRequiredNorStoredInSession()
{
$this->CallStartAndCheckLoginModeStored(null, null);
}

public function testOnStart_StoreLoginModeRequiredWhenConfigured()
{
MetaModel::GetConfig()->SetAllowedLoginTypes(["SAML"]);
$_REQUEST['login_mode'] = "SAML";

$this->CallStartAndCheckLoginModeStored("SAML", null);
}

public function testOnStart_SwitchLoginModeWhenNewOneRequiredIsConfigured()
{
MetaModel::GetConfig()->SetAllowedLoginTypes(["SAML"]);
$_REQUEST['login_mode'] = "SAML";

$this->CallStartAndCheckLoginModeStored("SAML");
}

public function testOnStart_PreserveCurrentLoginModeInSessionWhenNewOneRequiredIsNotConfigured()
{
$_REQUEST['login_mode'] = "SAML";

$this->CallStartAndCheckLoginModeStored("previous_mode");
}

public function testOnStart_PreserveCurrentLoginModeInSessionWhenNoOtherRequired()
{
$this->CallStartAndCheckLoginModeStored('previous_mode');
}

private function CallStartAndCheckLoginModeStored($expected, ?string $sPreviousLoginMode = 'previous_mode')
{
Session::Set('login_mode', $sPreviousLoginMode);

$iErrorCode = 666;
$res = $this->InvokeNonPublicMethod(LoginDefaultBefore::class, 'OnStart', new LoginDefaultBefore(), [&$iErrorCode]);
$this->assertEquals(LoginWebPage::EXIT_CODE_OK, $iErrorCode);
$this->assertEquals(LoginWebPage::LOGIN_FSM_CONTINUE, $res);
$this->assertEquals($expected, Session::Get('login_mode'));
}
}
Loading