Shield Damage Multiplier

[ViralReaction]

Additions

Describe new functionality added by your code, e.g.

• Adds shield damage multiplier to shields
• Adds shield damage multiplier to interceptors
• Adds shield damage multiplier to CE's projectile properties
• Adds shield damage multiplier to SecondaryDamage properties
• Secondary damage now properly effects shields if Harmshealth bool is true on damageDef
• Mod Extension bool to allow non-"harms health" damage defs in secondary damage to affect shields (e.g. EMP)
• Mod Extension to set default shield damage multiplier for entire Damage Def (e.g. EMP set to 2.5x)

Balance

Baseline Shield Damage Multipliers (Subject To Final Balance Passes)

• EMP: 2.5x
• Basic Pellets: 0.25x

Changes

• CompShield takes damage modified by shield damage multiplier
• EMP instabreak changed to only work against infinite hp CompProjectileInterceptors. This is the default for RW, but a modded one will now take HP damage instead of instakilling

References

• Continuation of Add Shield Damage Multiplier #4008

Reasoning

Why did you choose to implement things this way, e.g.

• EMP's RNG of instakilling shields regardless of size makes little sense. Same round will take out a shield with HP value of float.MaxValue the same as a 300hp shield belt.
• Gives the ability to tailor EMP to still be extremely effective against shields, but also the ability to make other projectiles not great at all against them.
• EMP large bonus damage against shields due to logical and thematic reasons
• Shotgun pellets are extremely strong against shield belts, and makes sense that easier to disperse with a shield. Only reduced damage from shotgun/flechette style pellets of industrial and below nature. Spacer+ tried to leave alone for now
• Harms Health check needed to prevent things like Stun affecting shields

Alternatives

Describe alternative implementations you have considered, e.g.

• Completely remove instant shield breaking code

Testing

Check tests you have performed:

• Compiles without warnings
• Game runs without errors
• (For compatibility patches) ...with and without patched mod loaded
• Playtested a colony (specify how long)

To Do:

• Remove empShieldBreakChance from projectile xmls we want to use new system. (Currently issue of default CompProjectileInterceptors having hitpoints of -1. Would remove any counterplay)
• Determine balanced multipliers for projects and add in xml.
• Show multiplier on ammo information page
• Apply to secondary damage types.
• Determine what if anything is to be done for EMP AoE (grenades, mortars, etc.) in relation to this new system. (Appear to be working out of the box)

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-20322122599.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-20323685865.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-20323783618.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-20323849780.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-20324953220.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-20325384171.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-20325553476.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-20401441163.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-20417026137.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-20417588389.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-20419367767.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-20419405439.zip

[N7Huntsman]

No issues in my testing. We'll have to see what we think of the balance--may decide in future that we want a higher bonus that 2.5 for the shield multiplier.

[N7Huntsman]

No issues in my testing with the primary and area damage--though we may decide in future that we want a higher bonus that 2.5 for the shield multiplier depending on how we're feeling about balance.

However secondary EMP damage (through secondaryDamage) seems to still be using the older logic of random stun chance--expect it's stunning every time in my testing using the charge rifle ion rounds.

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-20462658043.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-20465415255.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-20465735472.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-20479297619.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-21116886496.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-21467044365.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-22429916304.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-22655633255.zip