ci: deploy homepage with github pages#194
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR adds a standalone static homepage that can be deployed via GitHub Pages, while also switching the API server’s homepage handler to serve the same HTML via go:embed.
Changes:
- Added a static homepage bundle (
index.html+.nojekyll) underinternal/api/http/static/homepage/. - Replaced the large inlined HTML constant in
homepage.gowith an embedded file. - Introduced a GitHub Actions workflow to publish the homepage directory to GitHub Pages on pushes to
main.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| internal/api/http/static/homepage/index.html | Adds the static homepage HTML/CSS/JS served by Pages and embedded by the API. |
| internal/api/http/static/homepage/.nojekyll | Disables Jekyll processing for the Pages artifact. |
| internal/api/http/homepage.go | Switches homepage HTML delivery from inline string to go:embed. |
| .github/workflows/homepage-pages.yml | Adds CI workflow to upload and deploy the homepage directory to GitHub Pages. |
Comment on lines
+517
to
+520
| runtimeStatus.innerHTML = | ||
| "<strong>Runtime detected:</strong> connected to " + | ||
| service + | ||
| ". Local shortcuts for /api/health, trace, and metrics are now available."; |
| (function () { | ||
| var runtimePanel = document.getElementById("runtime-links"); | ||
| var runtimeStatus = document.getElementById("runtime-status"); | ||
| var apiHealthURL = "api/health"; |
Comment on lines
+369
to
+371
| <a class="button" href="https://github.com/Colin4k1024/Aetheris/blob/main/docs/guides/quickstart.md" target="_blank" rel="noreferrer">Read quickstart</a> | ||
| <a class="button-secondary" href="https://github.com/Colin4k1024/Aetheris/blob/main/docs/reference/api.md" target="_blank" rel="noreferrer">Browse API</a> | ||
| <a class="button-secondary" href="https://github.com/Colin4k1024/Aetheris" target="_blank" rel="noreferrer">View repository</a> |
| @@ -0,0 +1 @@ | |||
|
|
|||
Comment on lines
+1
to
+3
| name: Homepage Pages | ||
|
|
||
| on: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Describe the change and why it is needed.
Changes
Validation
go test ./...go build ./...Compatibility / Risk
Call out breaking changes, migrations, or runtime risks.
Related Issues
Link related issues (e.g.
Closes #123).