Tidy the test-submission marker after review#31
Merged
Conversation
Cleanup from a code-quality pass (no behavior change):
- submit.py: drop the unused "test" key from the dry-run return dict (the CLI
tag derives from args.test, nothing reads the result key).
- verify_submission.py: bool(submission.get("test")) — the explicit False
default was redundant.
- submission.schema.json: move "test" into the optional-field cluster after
results (next to placeholder), drop the "Optional." lead-in for house style.
- score-from-r2.yml: comment the coarse whole-incoming/ archive, flagging that a
permanently-FAILing submission jams the queue until deleted by hand
(follow-up: archive per-file by FINISHED status).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018xw6L5yUrz33UrQpanbwnH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code-quality cleanup from a
/simplifypass — no behavior change:"test"key from the dry-run return dict (the CLI tag derives fromargs.test; nothing read the result key).bool(submission.get("test")); the explicitFalsedefault was redundant.testinto the optional-field cluster afterresults(next toplaceholder); drop theOptional.lead-in for house style.incoming/archive, flagging that a permanently-FAILing submission jams the queue until deleted by hand.Follow-up (not in this PR): archive per-file by FINISHED status so one poison submission can't block all publishing.
🤖 Generated with Claude Code
https://claude.ai/code/session_018xw6L5yUrz33UrQpanbwnH