fix: Correct create_scene argument passing and node ownership#18
Open
alienfrenZyNo1 wants to merge 1 commit intoCoding-Solo:mainfrom
Open
fix: Correct create_scene argument passing and node ownership#18alienfrenZyNo1 wants to merge 1 commit intoCoding-Solo:mainfrom
alienfrenZyNo1 wants to merge 1 commit intoCoding-Solo:mainfrom
Conversation
|
Well I can create scenes now using the ide but for some reason creating a node causes the ide to hang. Because it just hangs there I'm not getting any output or anything to look at and explain why. Huge thanks for solving one issue, let me know if you have any idea why creating a node may be causing the ide to hang now. edit: After messing around a small note. If I restart my ide it can then create a node, but after creating 1 node it can't do another. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON Argument Passing on Windows:
src/index.ts) to the Godot operations script (src/scripts/godot_operations.gd) were getting corrupted on Windows.child_process.spawnwithshell: trueand attempting Unix-style shell escaping, which doesn't work correctly in Windows shells (cmd/powershell).executeOperationinsrc/index.tsto usespawnwithshell: false. This allows Node.js to handle argument quoting correctly across platforms, and the raw JSON string can be passed directly without needing shell-specific escaping.Godot Node Ownership Error:
create_scenefunction insrc/scripts/godot_operations.gdwas failing with a Godot engine error:Condition "p_owner == this" is true.scene_root.owner = scene_rootbefore packing the scene.scene_root.owner = scene_rootline. ThePackedScene.pack()method correctly handles the ownership of the root node being packed.With these changes, the
create_scenetool now functions correctly, successfully creating scene files as intended.