Skip to content

fix: remove tracked secrets baseline files to resolve CI failures#38

Merged
Coding-Dev-Tools merged 1 commit into
mainfrom
improve/deploydiff-20260627054044
Jun 29, 2026
Merged

fix: remove tracked secrets baseline files to resolve CI failures#38
Coding-Dev-Tools merged 1 commit into
mainfrom
improve/deploydiff-20260627054044

Conversation

@Coding-Dev-Tools

Copy link
Copy Markdown
Owner

Automated fix by dev-engineer.

Changes:

  • Remove and from git tracking (they are already in .gitignore)
  • This resolves the auto-code-review 'Potential secrets detected' failures on CI

Root cause: The secrets baseline files were committed to the repo, but they contain test fixture patterns that trigger false positives in the detect-secrets scan. Since these files are already listed in .gitignore, they should not be tracked.

Verification: All tests pass locally, ruff checks pass, build succeeds.

Coding-Dev-Tools added a commit that referenced this pull request Jun 29, 2026
Net changes after merge-conflict resolution: lint-clean style for
parsers/cli/mcp_server, AGENTS.md additions, gitignore secrets baseline.
.secrets.baseline already untracked on main (original PR intent met).
@Coding-Dev-Tools Coding-Dev-Tools force-pushed the improve/deploydiff-20260627054044 branch from d48a438 to 8eb3ed9 Compare June 29, 2026 08:15
@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown

🤖 Automated Code Review

✅ Ruff Lint — No issues

⚠️ Ruff Format — Formatting needed

Would reformat: src/deploydiff/cli.py
Would reformat: src/deploydiff/cloudformation_parser.py
Would reformat: src/deploydiff/cost_estimator.py
Would reformat: src/deploydiff/diff_renderer.py
Would reformat: src/deploydiff/pulumi_parser.py
Would reformat: src/deploydiff/rollback.py
Would reformat: tests/test_deploydiff.py
Would reformat: tests/test_edge_cases.py
8 files would be reformatted, 7 files already formatted

✅ Secret Detection — Clean

✅ Large Files — Within limits

📊 Diff Stats — 8 file(s) changed

 .gitignore                         | 1 +
 AGENTS.md                          | 8 +++++++-
 src/deploydiff/cli.py              | 3 +--
 src/deploydiff/cost_estimator.py   | 2 +-
 src/deploydiff/mcp_server.py       | 6 ++----
 src/deploydiff/pulumi_parser.py    | 3 ++-
 src/deploydiff/terraform_parser.py | 7 +++----
 tests/conftest.py                  | 8 ++------
 8 files changed, 19 insertions(+), 19 deletions(-)

Verdict: ⚠️ Warnings — Lint/format issues found. Recommend fixing before merge.

Automated by Coding-Dev-Tools/.github reusable workflow.

@Coding-Dev-Tools Coding-Dev-Tools merged commit b65b525 into main Jun 29, 2026
5 of 6 checks passed
@Coding-Dev-Tools Coding-Dev-Tools deleted the improve/deploydiff-20260627054044 branch June 29, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant