[Hermes] Fix 18 ruff lint errors, add ruff CI gate, remove npm-publish.yml#13
Merged
Coding-Dev-Tools merged 1 commit intoMay 18, 2026
Conversation
…h.yml - Fix 13 unused import errors (F401) across cli.py, converters.py, tests - Fix 1 f-string without placeholders (F541) in cli.py - Fix 5 import ordering errors (I001) across all source files - Fix 1 line-too-long (E501) in cli.py validate command decorator - Add [tool.ruff] config to pyproject.toml (target py310, line-length 120) - Add lint job to CI (test.yml) with ruff check step, test depends on lint - Remove npm-publish.yml (incorrect for Python project, has publish.yml for PyPI)
Coding-Dev-Tools
deleted the
hermes/datamorph/fix-ruff-add-ci-remove-npm-publish
branch
Coding-Dev-Tools
added a commit
that referenced
this pull request
May 18, 2026
* fix: restore npm-publish.yml — repo has legitimate npm wrapper The npm-publish.yml was incorrectly removed in PR #13 (alongside legitimate ruff fixes). This repo has a legitimate npm wrapper (package.json + cli.js) that allows users to install via 'npm install -g datamorph-cli'. The npm-publish workflow is needed to publish this wrapper to the npm registry. Reverts the npm-publish.yml removal from commit 8a7edca. * fix: bump actions/checkout to v6 in pages.yml and add missing test coverage - Fix version mismatch: actions/checkout@v4 → @v6 in pages.yml (other workflows were already bumped via dependabot PR #2) - Add TestJsonlConversion: JSONL format was completely untested - Add TestBatchConversion: convert_batch() direct test coverage - Add TestTypeInference: _infer_type() with bool, None, date edge cases - Add TestTypeWidening: _widen_type() with all widening combinations - Add CLI --stream flag and formats streaming display tests --------- Co-authored-by: DevForge Engineer <engineer@devforge.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix all ruff lint errors in datamorph, add a ruff lint CI gate, and remove the incorrect npm-publish.yml workflow.
Why this change
What changed
Validation performed
ruff check .→ All checks passedpytest tests/ -q→ 62 passed in 1.04sRisks / Rollback
Follow-ups