Embed mermaid visuals in core docs#2
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ebfd98def7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const pages = [ | ||
| { title: "Overview", href: "pages/overview.html" }, | ||
| { title: "Service Definition", href: "pages/service-definition.html" }, | ||
| { title: "Operating Model", href: "pages/operating-model.html" }, |
There was a problem hiding this comment.
The pages array uses href: "pages/...", which works only from site/index.html. When app.js runs on site/pages/*.html (loaded via ../assets/app.js), those links resolve relative to the subpage and become site/pages/pages/..., so the navigation and search results 404 unless the user is on the root index. Consider computing a base path from window.location or using paths that are correct for both locations (e.g., ../pages/... on subpages or root-relative paths if you serve from a web root).
Useful? React with 👍 / 👎.
Motivation
Description
docs/00-executive-overview.md,docs/04-reference-architecture.md,docs/05-operating-model.md,docs/11-incident-response.md,docs/12-change-and-release.md,docs/13-exception-handling.md,docs/16-logging-monitoring-siem.md, anddocs/19-devsecops-pipelines.md.docs/22-diagrams/so the inline visuals and canonical.mmdsources remain linked.Testing
.github/workflows/ci.ymlthat will validate Markdown, run a link check, verify Mermaid blocks, and validate JSON formatting when the workflow is triggered.Codex Task