Conversation
JamalMakame
commented
Oct 17, 2022
JamalMakame
commented
- added responsive
- navbar refactored blog code
Contributor
|
Interesting... |
| HeaderItem(title: 'CONTACT', onTap: () {}), | ||
| ]; | ||
|
|
||
| Widget headerLogo(BuildContext context) { |
There was a problem hiding this comment.
Doubt:
Why use help methods in this case instead of widgets?
I think it would be nice to follow best practices, as the Flutter team recommends.
| const HeaderMenuTile(), | ||
| headerRow(context), | ||
|
|
||
| // visible: false, |
| textStyle: buttonTextStyle, | ||
| padding: const EdgeInsets.symmetric(horizontal: 16, vertical: 16)); | ||
| backgroundColor: Colors.transparent, | ||
| //onSurface: null, |
| import 'package:flutter/material.dart'; | ||
|
|
||
| class Globals { | ||
| static GlobalKey<ScaffoldState> scaffoldKey = GlobalKey<ScaffoldState>(); |
There was a problem hiding this comment.
Why? Remember that keys must be unique.
I don't know if there's a need to create a class for this, because it won't be reused at other times. 💭
There was a problem hiding this comment.
Now I understanding this better, after read this.
Contributor
|
@felipecastrosales raises some good points. Can you make a new updated PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.