This repository was archived by the owner on Aug 17, 2024. It is now read-only.
Steve express-workshop #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthewWood
reviewed
Jul 21, 2018
| console.log("Saved!"); | ||
| }); | ||
|
|
||
| fs.appendFile("data/posts.json", json(req.fields), function(error) { |
There was a problem hiding this comment.
Does this append the data in a format which you are able to read it again?
|
|
||
| const fs = require("fs"); | ||
|
|
||
| fs.appendFile("message.txt", "data to append", function(err) { |
There was a problem hiding this comment.
What is the reason for appending the data to 2 files: message.txt and data/posts.json?
| res.end("Thank you for submitting the form!"); | ||
| }); | ||
|
|
||
| fs.readFile(__dirname + "/data/posts.json", function(error, file) { |
There was a problem hiding this comment.
This code is not attached to any route. This means it will only be executed once at startup and then never again. Did you manage to make it work?
nennes
reviewed
Jul 21, 2018
| const app = express(); | ||
| const formidable = require("express-formidable"); | ||
| const fs = require("fs"); | ||
| // const http = require("http"); |
There was a problem hiding this comment.
In general it's not a god prctice to live commented code into git. Something is either needed / works or not. Commented code is a grey area that confuses everyone else.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Please review my file.
Thank you and regards,
Steve