Birmingham | 2026-MAR-SDC | Joy Opachavalit | Sprint 4 | Implement shell tools in python by enjoy15 · Pull Request #497 · CodeYourFuture/Module-Tools

enjoy15 · 2026-04-15T21:02:36Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Completed all exercises

LonMcGregor

Good start, but there is some work left to do here.

Is there a package you could use to help with managing arguments? Right now it is a bit complex, and you can't combine single-letter arguments like the command line tools.

LonMcGregor

Good work switching to using the argparse library. I do have some questions, as it looks like you are maybe not using the library as effectively as you could be.

LonMcGregor · 2026-06-10T09:22:24Z

Thanks for replying @enjoy15 - Could you try implementing the ls using the standard argparse without subclassing or adding custom functions? It would help to reduce the amount of code that you have written, making it more readable and maintainable

enjoy15 · 2026-06-11T21:49:57Z

@LonMcGregor Suggestion implemented. Thank you!

LonMcGregor

Great, this looks a lot cleaner now. One question, see my comment

LonMcGregor

The -1 is no longer required, but I think you still need to think about how the -1 argument works, see my comment

LonMcGregor · 2026-06-17T09:57:23Z

+
+    locale.setlocale(locale.LC_COLLATE, "")
+    for entry in sorted(entries, key=locale.strxfrm):
+        print(entry)


Think about the purpose of the -1 argument. How should the output differ when it is activated and when it is not? Does your implementation meet that expectation?

Thank you for the catch! I realized that my original implementation was always printing one item per line, meaning the -1 flag wasn't actually changing the behavior.

I have updated the code so that it now checks for the one_per_line argument. If it's active, it prints one entry per line; otherwise, it outputs the entries horizontally, separated by spaces, to mimic the default ls behavior.

LonMcGregor

Thanks, this ls implementation matches the spec now. well done

enjoy15 · 2026-06-19T18:43:04Z

Thanks, this ls implementation matches the spec now. well done

Thank you!

enjoy15 added 5 commits April 12, 2026 22:10

complete wc exercise

54968b5

complete wc exercise2

deb9f0c

complete cat exercise

34e5d9d

Refactor wc.py to streamline file counting and output formatting

49c33ed

complete ls exercise

91a136b

enjoy15 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 4 Assigned during Sprint 4 of this module labels Apr 15, 2026

LonMcGregor reviewed Jun 3, 2026

View reviewed changes

Comment thread implement-shell-tools/ls/ls.py

LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 3, 2026

enjoy15 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 4, 2026

LonMcGregor removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 8, 2026

Refactor ls.py to enhance argument parsing and error handling

5fae0a2

enjoy15 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 8, 2026

LonMcGregor reviewed Jun 9, 2026

View reviewed changes

Comment thread implement-shell-tools/ls/ls.py Outdated

Comment thread implement-shell-tools/ls/ls.py Outdated

LonMcGregor removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 9, 2026

enjoy15 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 9, 2026

LonMcGregor removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 10, 2026

Refactor ls.py to simplify argument parsing and improve error handling

f66e681

enjoy15 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 11, 2026

LonMcGregor reviewed Jun 16, 2026

View reviewed changes

Comment thread implement-shell-tools/ls/ls.py Outdated

LonMcGregor removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 16, 2026

update ls.py not to enforce -1

624d761

enjoy15 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 16, 2026

LonMcGregor reviewed Jun 17, 2026

View reviewed changes

LonMcGregor removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 17, 2026

update -1 logic

6b8a25d

enjoy15 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 17, 2026

LonMcGregor reviewed Jun 19, 2026

View reviewed changes

Uh oh!

Uh oh!

Conversation

enjoy15 commented Apr 15, 2026

Learners, PR Template

Changelist

Uh oh!

LonMcGregor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

LonMcGregor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

LonMcGregor commented Jun 10, 2026

Uh oh!

enjoy15 commented Jun 11, 2026

Uh oh!

LonMcGregor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

LonMcGregor left a comment

Choose a reason for hiding this comment

Uh oh!

LonMcGregor Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

enjoy15 Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

LonMcGregor left a comment

Choose a reason for hiding this comment

Uh oh!

enjoy15 commented Jun 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants