Manchester | 25-ITP-Sep | Khalidbih | Sprint 2 | coursework/sprint-2 #854

khalidbih · 2025-11-07T23:50:19Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I completed all exercises in Sprint-2, except the last one, 5-stretch-extend/format-time.js.

github-actions · 2025-11-07T23:50:40Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-07T23:51:14Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-07T23:51:15Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-07T23:51:20Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

cjyuan

This branch contains some unrelated changes in the Sprint-1 folder. Can you revert those changes to keep this branch clean?

cjyuan · 2025-11-08T13:09:56Z

Sprint-2/3-mandatory-implement/1-bmi.js

+    let BMI = weight / (height * height);
+    let rounded = Math.round(BMI * 10) / 10;


Did you notice the variables rounded and BMI are rendered in different colors?

Many IDEs and viewers that support syntax highlighting (including GitHub) display identifiers in different formats and colors.

let bmi, camelCase; let Bmi, PascalCase; let BMI, UPPER_SNAKE_CASE;

Can you look up the naming conventions in JavaScript? In particular,

Variable and function names

Class and Types names

Named constants

Then, update the variable names according to those conventions.

On separate note, it is a good practice to declare a "variable" using const instead of let when the variable is not going to be reassigned a value.

Thank you! I have changed let to const and checked the variable naming.

cjyuan · 2025-11-08T13:13:16Z

Sprint-2/3-mandatory-implement/3-to-pounds.js

+function toPounds (penceString) { 
+
+
+const penceStringWithoutTrailingP = penceString.substring (
+  0,
+  penceString.length - 1
+);
+
+const paddedPenceNumberString = penceStringWithoutTrailingP.padStart(3, "0");
+const pounds = paddedPenceNumberString.substring(
+  0,
+  paddedPenceNumberString.length - 2
+);
+
+const pence = paddedPenceNumberString
+  .substring(paddedPenceNumberString.length - 2)
+  .padEnd(2, "0");
+  return `£${pounds}.${pence}`;
+}


The indentation of the code is a bit off.

Suggestion: You can use this VSCode feature to auto indent JS code.
https://code.visualstudio.com/docs/languages/javascript#_formatting

Thank you for the link! I’ll make sure to keep the indentation consistent next time.

Deleted unrelated Sprint-1 files that were mistakenly included in the Sprint-2 branch to keep the PR clean.

… for non-reassigned variables

khalidbih · 2025-11-11T23:02:23Z

This branch contains some unrelated changes in the Sprint-1 folder. Can you revert those changes to keep this branch clean?

Sorry about the confusion! I’ve deleted the unrelated changes to keep this branch clean.

cjyuan

Changes to the code look good. However, the branch is still not quite clean.

Deleted files are still considered as "changed files". "Revert the changes made in the Sprint-1 folder" means to "undo the changes made in that folder. That is, we need to make the files in the Sprint-1 folder identical to their original version (the version in the main branch).
One way to achieve that is to replace the files by the version of the files in main.

khalidbih · 2025-11-12T13:23:54Z

Changes to the code look good. However, the branch is still not quite clean.

Deleted files are still considered as "changed files". "Revert the changes made in the Sprint-1 folder" means to "undo the changes made in that folder. That is, we need to make the files in the Sprint-1 folder identical to their original version (the version in the main branch). One way to achieve that is to replace the files by the version of the files in main.

.Sprint-1 files have been restored to main and removed from this PR to keep the changes focused and clean.

cjyuan · 2025-11-12T14:11:08Z

Branch is clean now. Well done.

khalidbih · 2025-11-12T14:21:13Z

Branch is clean now. Well done.

Thank you so much for your guidance. I really appreciate it.

khalidbih added 16 commits October 30, 2025 15:39

I fixed the error and wrote a new code, it runs perfectly

07075e1

I fixed the error and wrote a new code, it runs perfectly

7291d85

Fix convertToPercentage function; now returns correct 50% output

e838340

I had to delete the broken code

9bcb86b

Corrected square function; prints 9 for input 3

b4435a7

Fixed multiply function to return correct output

ccf9b9b

Updated variable names

3ae35f7

I fixed errors and its able to run the code

f5a273a

I changed the console.log

3960c56

I fixed the return

e7be3d3

exercise completed

3557fef

I used toUpperSnakeCase as the function name

41416d5

I added reusable toPounds function

770c94a

This exercise complete

f425e8a

I Fixed the code to get parts of filePath; runs correctly

b953519

format-time.js in Sprint-2

f976015

khalidbih added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Nov 7, 2025

cjyuan reviewed Nov 8, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 8, 2025

khalidbih added 4 commits November 8, 2025 14:12

I Removed unrelated Sprint-1 files from Sprint-2 PR

2579613

Deleted unrelated Sprint-1 files that were mistakenly included in the Sprint-2 branch to keep the PR clean.

I Removed unrelated Sprint-1 files from Sprint-2 PR

7f0b538

Deleted unrelated Sprint-1 files that were mistakenly included in the Sprint-2 branch to keep the PR clean.

I Removed unrelated Sprint-1 files from Sprint-2 PR

e679e68

Deleted unrelated Sprint-1 files that were mistakenly included in the Sprint-2 branch to keep the PR clean.

I removed Sprint-1 files from Sprint-2 PR

34ea901

Deleted unrelated Sprint-1 files that were mistakenly included in the Sprint-2 branch to keep the PR clean.

khalidbih added 2 commits November 11, 2025 22:31

Applied JS naming conventions (camelCase) and replaced let with const…

4680d18

… for non-reassigned variables

Applied JS naming conventions (camelCase) and replaced let with const…

ab9067e

… for non-reassigned variables

khalidbih added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 11, 2025

cjyuan reviewed Nov 12, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 12, 2025

Revert Sprint-1 folder to match main branch

7148bb6

khalidbih added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 12, 2025

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 12, 2025

khalidbih mentioned this pull request Nov 22, 2025

25-ITP-Sep | Module-Structuring-and-Testing-Data | khalidbih khalidbih/My-Coursework-Planner#32

Open

		let BMI = weight / (height * height);
		let rounded = Math.round(BMI * 10) / 10;

Uh oh!

Manchester | 25-ITP-Sep | Khalidbih | Sprint 2 | coursework/sprint-2 #854

Are you sure you want to change the base?

Manchester | 25-ITP-Sep | Khalidbih | Sprint 2 | coursework/sprint-2 #854

Uh oh!

Conversation

khalidbih commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelist

Uh oh!

github-actions bot commented Nov 7, 2025

Uh oh!

github-actions bot commented Nov 7, 2025

Uh oh!

github-actions bot commented Nov 7, 2025

Uh oh!

github-actions bot commented Nov 7, 2025

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

khalidbih Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

khalidbih Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

khalidbih commented Nov 11, 2025

Uh oh!

cjyuan left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

khalidbih commented Nov 12, 2025

Uh oh!

cjyuan commented Nov 12, 2025

Uh oh!

khalidbih commented Nov 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

khalidbih commented Nov 7, 2025 •

edited

Loading

cjyuan left a comment •

edited

Loading