West Midlands | ITP-SEPT-25 | Georgina Rogers | Sprint 3 | Implement and rewrite tests

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

@@ -1,20 +1,20 @@
-// Implement a function getAngleType
-// Build up your function case by case, writing tests as you go
-// The first test and case is written for you. The next case has a test, but no code.
-// Execute this script in your terminal
-// node 1-get-angle-type.js
-// The assertion error will tell you what the expected output is
-// Write the code to pass the test
-// Then, write the next test! :) Go through this process until all the cases are implemented
-
 function getAngleType(angle) {
   if (angle === 90) {
     return "Right angle";
   }
-   // Run the tests, work out what Case 2 is testing, and implement the required code here.
-   // Then keep going for the other cases, one at a time.
+  if (angle < 90) {
+    return "Acute angle";
+  }
+  if (angle > 90 && angle < 180) {
+    return "Obtuse angle";
+  }
+  if (angle === 180) {
+    return "Straight angle";
+  }
+  if (angle > 180 && angle < 360) {
+    return "Reflex angle";
+  }
 }
-
 // The line below allows us to load the getAngleType function into tests in other files.
 // This will be useful in the "rewrite tests with jest" step.
 module.exports = getAngleType;
@@ -28,12 +28,6 @@ function assertEquals(actualOutput, targetOutput) {
   );
 }
 
-// Acceptance criteria:
-
-// Given an angle in degrees,
-// When the function getAngleType is called with this angle,
-// Then it should:
-
 // Case 1: Identify Right Angles:
 // When the angle is exactly 90 degrees,
 // Then the function should return "Right angle"
@@ -50,14 +44,16 @@ assertEquals(acute, "Acute angle");
 // When the angle is greater than 90 degrees and less than 180 degrees,
 // Then the function should return "Obtuse angle"
 const obtuse = getAngleType(120);
-// ====> write your test here, and then add a line to pass the test in the function above
+assertEquals(obtuse, "Obtuse angle");
 
 // Case 4: Identify Straight Angles:
 // When the angle is exactly 180 degrees,
 // Then the function should return "Straight angle"
-// ====> write your test here, and then add a line to pass the test in the function above
+const straight = getAngleType(180);
+assertEquals(straight, "Straight angle");
 
 // Case 5: Identify Reflex Angles:
 // When the angle is greater than 180 degrees and less than 360 degrees,
 // Then the function should return "Reflex angle"
-// ====> write your test here, and then add a line to pass the test in the function above
+const reflex = getAngleType(250);
+assertEquals(reflex, "Reflex angle");

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -1,15 +1,8 @@
-// Implement a function isProperFraction
-// Write assertions for your function to check it works in different cases
-// Terms:
-// Fractions: https://www.bbc.co.uk/bitesize/topics/zt9n6g8/articles/zjxpp4j
-// Written here like this: 1/2 == Numerator/Denominator
-// the first test and first case is written for you
-// complete the rest of the tests and cases
-// write one test at a time, and make it pass, build your solution up methodically
-
 function isProperFraction(numerator, denominator) {
-  if (numerator < denominator) {
+  if (Math.abs(numerator) < Math.abs(denominator)) {
     return true;
+  } else {
+    return false;
   }
 }
 
@@ -25,35 +18,55 @@ function assertEquals(actualOutput, targetOutput) {
   );
 }
 
-// Acceptance criteria:
-
+// Case 1
 // Proper Fraction check:
 // Input: numerator = 2, denominator = 3
 // target output: true
 // Explanation: The fraction 2/3 is a proper fraction, where the numerator is less than the denominator. The function should return true.
 const properFraction = isProperFraction(2, 3);
 assertEquals(properFraction, true);
 
+//Case 2
 // Improper Fraction check:
 // Input: numerator = 5, denominator = 2
 // target output: false
 // Explanation: The fraction 5/2 is an improper fraction, where the numerator is greater than or equal to the denominator. The function should return false.
 const improperFraction = isProperFraction(5, 2);
 assertEquals(improperFraction, false);
 
+//Case 3
 // Negative Fraction check:
 // Input: numerator = -4, denominator = 7
 // target output: true
 // Explanation: The fraction -4/7 is a proper fraction because the absolute value of the numerator (4) is less than the denominator (7). The function should return true.
 const negativeFraction = isProperFraction(-4, 7);
-// ====> complete with your assertion
+assertEquals(negativeFraction, true);
+//The function already works for negative numerators, so no changes are needed.
 
+//case 4
 // Equal Numerator and Denominator check:
 // Input: numerator = 3, denominator = 3
 // target output: false
 // Explanation: The fraction 3/3 is not a proper fraction because the numerator is equal to the denominator. The function should return false.
 const equalFraction = isProperFraction(3, 3);
-// ====> complete with your assertion
+assertEquals(equalFraction, false);
 
 // Stretch:
 // What other scenarios could you test for?
+// Case 5
+//Negative denominator
+const negativeDenominator = isProperFraction(4, -5);
+assertEquals(negativeDenominator, true);
+// Explanation: The fraction 4/-5 is a proper fraction because the absolute value of the numerator (4) is less than the absolute value of the denominator (5). The function should return true.
+
+// Case 6
+//Both numerator and denominator negative
+const bothNegative = isProperFraction(-3, -4);
+assertEquals(bothNegative, true);
+// Explanation: The fraction -3/-4 is a proper fraction because the absolute value of the numerator (3) is less than the absolute value of the denominator (4). The function should return true.
+
+// Case 7
+//Zero numerator
+const zeroNumerator = isProperFraction(0, 5);
+assertEquals(zeroNumerator, true);
+// Explanation: The fraction 0/5 is a proper fraction because the numerator (0) is less than the denominator (5). The function should return true.

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -1,16 +1,17 @@
-// This problem involves playing cards: https://en.wikipedia.org/wiki/Standard_52-card_deck
-
-// You will need to implement a function getCardValue
-// the function takes a single parameter, a string representing a playing card
-// the function should return the numerical value of the card
-// the first test and first case is written for you
-// complete the rest of the tests and cases
-// write one test at a time, and make it pass, build your solution up methodically
-// just make one change at a time -- don't rush -- programmers are deep and careful thinkers
 function getCardValue(card) {
+  const rank = card.slice(0, -1);
   if (rank === "A") {
     return 11;
   }
+  if (/^(?:[2-9]|10)$/.test(rank)) {
+    return Number(rank);
+  } // Matches strings of only whole numbers 2-10
+  // Handle 10 separately to avoid matching '1' alone
+  if (["J", "Q", "K"].includes(rank)) {
+    return 10;
+  } else {
+    throw new Error("Invalid card rank");
+  }
 }
 
 // The line below allows us to load the getCardValue function into tests in other files.
@@ -26,32 +27,41 @@ function assertEquals(actualOutput, targetOutput) {
     `Expected ${actualOutput} to equal ${targetOutput}`
   );
 }
-// Acceptance criteria:
 
+// Case 1
 // Given a card string in the format "A♠" (representing a card in blackjack - the last character will always be an emoji for a suit, and all characters before will be a number 2-10, or one letter of J, Q, K, A),
 // When the function getCardValue is called with this card string as input,
 // Then it should return the numerical card value
 const aceofSpades = getCardValue("A♠");
 assertEquals(aceofSpades, 11);
 
+// Case 2
 // Handle Number Cards (2-10):
 // Given a card with a rank between "2" and "9",
 // When the function is called with such a card,
 // Then it should return the numeric value corresponding to the rank (e.g., "5" should return 5).
 const fiveofHearts = getCardValue("5♥");
-// ====> write your test here, and then add a line to pass the test in the function above
+assertEquals(fiveofHearts, 5);
 
+// Case 3
 // Handle Face Cards (J, Q, K):
 // Given a card with a rank of "10," "J," "Q," or "K",
 // When the function is called with such a card,
 // Then it should return the value 10, as these cards are worth 10 points each in blackjack.
+const kingofDiamonds = getCardValue("K♦");
+assertEquals(kingofDiamonds, 10);
 
-// Handle Ace (A):
-// Given a card with a rank of "A",
-// When the function is called with an Ace,
-// Then it should, by default, assume the Ace is worth 11 points, which is a common rule in blackjack.
-
+// Case 4
 // Handle Invalid Cards:
 // Given a card with an invalid rank (neither a number nor a recognized face card),
 // When the function is called with such a card,
 // Then it should throw an error indicating "Invalid card rank."
+try {
+  getCardValue("1♣");
+  console.assert(false, "Expected error for invalid card");
+} catch (error) {
+  console.assert(
+    error.message === "Invalid card rank",
+    `Expected "Invalid card rank" error, but got: ${error.message}`
+  );
+}

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

@@ -10,17 +10,25 @@ test("should identify right angle (90°)", () => {
 // make your test descriptions as clear and readable as possible
 
 // Case 2: Identify Acute Angles:
-// When the angle is less than 90 degrees,
-// Then the function should return "Acute angle"
+test("should identify acute angle (<90°)", () => {
+  // Call the function with an angle less than 90 degrees
+  expect(getAngleType(45)).toEqual("Acute angle"); // Function is expected to return "Acute angle"
+});
 
 // Case 3: Identify Obtuse Angles:
-// When the angle is greater than 90 degrees and less than 180 degrees,
-// Then the function should return "Obtuse angle"
+test("should identify obtuse angle (>90° and <180°)", () => {
+  // Call the function with an angle greater than 90 degrees and less than 180 degrees
+  expect(getAngleType(120)).toEqual("Obtuse angle"); // Function is expected to return "Obtuse angle"
+});
 
 // Case 4: Identify Straight Angles:
-// When the angle is exactly 180 degrees,
-// Then the function should return "Straight angle"
+test("should identify straight angle (180°)", () => {
+  // Call the function with an angle of exactly 180 degrees
+  expect(getAngleType(180)).toEqual("Straight angle"); // Function is expected to return "Straight angle"
+});
 
 // Case 5: Identify Reflex Angles:
-// When the angle is greater than 180 degrees and less than 360 degrees,
-// Then the function should return "Reflex angle"
+test("should identify reflex angle (>180° and <360°)", () => {
+  // Call the function with an angle greater than 180 degrees and less than 360 degrees
+  expect(getAngleType(270)).toEqual("Reflex angle"); // Function is expected to return "Reflex angle"
+});

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -2,12 +2,27 @@
 // We will use the same function, but write tests for it using Jest in this file.
 const isProperFraction = require("../implement/2-is-proper-fraction");
 
-test("should return true for a proper fraction", () => {
+test("should return true for a proper fraction, including negatives", () => {
   expect(isProperFraction(2, 3)).toEqual(true);
+  expect(isProperFraction(-2, 3)).toEqual(true);
+  expect(isProperFraction(4, -5)).toEqual(true);
+  expect(isProperFraction(-4, -5)).toEqual(true);
 });
 
 // Case 2: Identify Improper Fractions:
+test("should return false for an improper fraction, including negatives", () => {
+  expect(isProperFraction(5, 4)).toEqual(false); //  numerator greater than denominator
+  expect(isProperFraction(5, -4)).toEqual(false); // negative denominator
+  expect(isProperFraction(-5, 4)).toEqual(false); // negative numerator
+  expect(isProperFraction(-5, -4)).toEqual(false); // both negative
+});
 
 // Case 3: Identify Negative Fractions:
+test("should return true for a negative fraction", () => {
+  expect(isProperFraction(-3, 4)).toEqual(true);
+});
 
 // Case 4: Identify Equal Numerator and Denominator:
+test("should return false for equal numerator and denominator", () => {
+  expect(isProperFraction(3, 3)).toEqual(false);
+});

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -2,12 +2,38 @@
 // We will use the same function, but write tests for it using Jest in this file.
 const getCardValue = require("../implement/3-get-card-value");
 
-test("should return 11 for Ace of Spades", () => {
-  const aceofSpades = getCardValue("A♠");
-  expect(aceofSpades).toEqual(11);
-});
+test("should return 11 for all Aces", () => {
+  const suits = ["♠", "♥", "♦", "♣"];
+  for (const suit of suits) {
+    expect(getCardValue(`A${suit}`)).toEqual(11);
+  }
+}); // One array handles all suits for Aces
 
 // Case 2: Handle Number Cards (2-10):
+test("should return correct value for number cards (2-10)", () => {
+  const suits = ["♠", "♥", "♦", "♣"];
+  for (let i = 2; i <= 10; i++) {
+    for (const suit of suits) {
+      expect(getCardValue(`${i}${suit}`)).toEqual(i);
+    }
+  }
+}); // Loop through numbers 2-10 for all suits; 36 test cases
+
 // Case 3: Handle Face Cards (J, Q, K):
-// Case 4: Handle Ace (A):
-// Case 5: Handle Invalid Cards:
+test("should return 10 for all face cards (J, Q, K)", () => {
+  const faceCards = ["J", "Q", "K"];
+  const suits = ["♠", "♥", "♦", "♣"];
+  for (const card of faceCards) {
+    for (const suit of suits) {
+      expect(getCardValue(`${card}${suit}`)).toEqual(10);
+    }
+  }
+}); // Loop through face cards for all suits; 12 test cases
+
+// Case 4: Handle Invalid Cards:
+test("should throw error for all invalid cards", () => {
+  const invalidCards = ["1♣", "11♦", "B♠", "Z♥", "15♣", "", " "];
+  for (const card of invalidCards) {
+    expect(() => getCardValue(card)).toThrow("Invalid card rank");
+  }
+}); // Loop through all invalid cards; 7 test cases

Sprint-3/2-practice-tdd/count.js

@@ -1,5 +1,11 @@
 function countChar(stringOfCharacters, findCharacter) {
-  return 5
+  let count = 0;
+  for (let i = 0; i < stringOfCharacters.length; i++) {
+    if (stringOfCharacters[i] === findCharacter) {
+      count++;
+    }
+  }
+  return count;
 }
 
 module.exports = countChar;

Sprint-3/2-practice-tdd/count.test.js

@@ -22,3 +22,9 @@ test("should count multiple occurrences of a character", () => {
 // And a character char that does not exist within the case-sensitive str,
 // When the function is called with these inputs,
 // Then it should return 0, indicating that no occurrences of the char were found in the case-sensitive str.
+test("should return 0 when character does not exist in string", () => {
+  const str = "hello world";
+  const char = "a";
+  const count = countChar(str, char);
+  expect(count).toEqual(0);
+});