West Midlands | ITP-Sept-2025 | Ali Naru | Sprint 3 | Coursework/sprint 3 implement and rewrite #845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohammedNaru
force-pushed
the
coursework/sprint-3-implement-and-rewrite
branch
4 times, most recently
from
e7b4c8b to
d40619a
Compare
MohammedNaru
force-pushed
the
coursework/sprint-3-implement-and-rewrite
branch
from
d40619a to
5dc9452
Compare
MohammedNaru
force-pushed
the
coursework/sprint-3-implement-and-rewrite
branch
from
9ac8d6e to
6082322
Compare
…corresponding tests
…lete assertions for all test cases
… face cards, and invalid inputs
…ds, face cards, Aces, and invalid inputs
MohammedNaru
added
Needs Review
cjyuan
added
Review in progress
cjyuan
reviewed
Nov 15, 2025
Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js
Show resolved
Hide resolved
Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js
Outdated
Show resolved
Hide resolved
Comment on lines
+17
to
+21
| // When the numerator is negative but absolute value < denominator, | ||
| // Then the function should return true | ||
| test("should return true for a negative proper fraction (|numerator| < denominator)", () => { | ||
| expect(isProperFraction(-4, 7)).toEqual(true); | ||
| }); |
Contributor
There was a problem hiding this comment.
To make the tests cover all possible categories, you can consider including a test for negative improper fractions.
Author
There was a problem hiding this comment.
I’ve updated the implementation based on feedback to make it more robust and complete. For isProperFraction, I added an additional test case to cover negative improper fractions, ensuring full coverage across all fraction categories. For getCardValue, I improved the rank parsing by validating numeric ranges properly rather than relying on a fixed list, and clarified handling of both face cards and invalid input by adding stricter validation. This should now behave more reliably and align better with real-world card value rules. Let me know if any further tweaks are needed!
cjyuan
added
Reviewed
…e test organization
…nction with rank handling
MohammedNaru
added
Needs Review
…es and improve error handling
…inal cases and improve error handling" This reverts commit b489194.
Contributor
|
Changes look good. Well done. |
cjyuan
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coursework/sprint 3 implement and rewrite
Self checklist
Changelist
Pull request complete, all tests working and passed successfully
Questions
no current questions for review.