Skip to content

Conversation

@Abayie
Copy link

@Abayie Abayie commented Oct 30, 2025

Learners, PR Template

Self checklist

  • [x ] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • [x ] My changes meet the requirements of the task
  • [x ] I have tested my changes
  • [x ] My changes follow the style guide

Changelist

This pull request improves code readability and data formatting for Sprint 1 of Module-Structuring-and-Testing-Data.
I refactored programs to clearly convert and format values, such as transforming pence strings to pounds, formatting time values, and calculating percentage changes.
Each solution includes step-by-step breakdowns and explanations, ensuring the code is easy to follow and works correctly for different input cases.

Questions

No questions at this point

// Line 1 is a variable declaration, creating the count variable with an initial value of 0
// Describe what line 3 is doing, in particular focus on what = is doing

/*Line 3 is reassigning variable count with a new value, in this case we're saying add 1 to whatever we already have in count,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very detailed! @Abayie


//let initials = [firstName, middleName, lastName].map(name => name.slice(0,1)).join('')

let initials = [firstName, middleName, lastName]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Solution is very good.
It correctly outputs "CKJ", without hard-coding any letters.

console.log(`The base part of ${filePath} is ${base}`);

// Create a variable to store the dir part of the filePath variable
const dir = filePath.slice(0, lastSlashIndex); // Extract the directory part (everything before the last slash)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good — clear, descriptive variable, and the path includes both directory and extension so the task is realistic

Copy link

@jaymes15 jaymes15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work!

@jaymes15 jaymes15 added 📅 Sprint 1 Assigned during Sprint 1 of this module Complete Volunteer to add when work is complete and all review comments have been addressed. labels Nov 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants