Glasgow | 25-ITP-Sep | Hanna Mykytiuk | Sprint 3 | Stretch #816

HannaOdud · 2025-10-28T02:33:20Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Stretch tasks.

Questions

Ask any questions you have for your reviewer.

github-actions · 2025-10-28T02:33:36Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-28T02:33:58Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-28T02:34:00Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-02T12:03:23Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-02T12:03:24Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

jaymes15 · 2025-11-02T12:11:09Z

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

 function getAngleType(angle) {
  if (angle === 90) {
    return "Right angle";
  }


@HannaOdud Great job! You’ve implemented all five cases correctly. Your logic is solid and the code reads clearly

Thanks a lot!

jaymes15 · 2025-11-02T12:12:15Z

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

+  else if (angle > 180 && angle < 360) {
+    return "Reflex angle"
+  }
+


@HannaOdud Any thoughts on how we might handle invalid angles (like negatives or values over 360)?

Thanks, I have changed it.

jaymes15 · 2025-11-02T12:13:46Z

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

    return "Right angle";
  }
+  else if (angle < 90) {
+    return "Acute angle"


For consistency, it’d be a good idea to add semicolons after each return statement (like return "Acute angle";) throughout the function.

Yessss. :-) Thanks!

jaymes15 · 2025-11-02T12:16:04Z

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

-  if (numerator < denominator) {
-    return true;
-  }
+  return (Math.abs(numerator) < Math.abs(denominator))


Nice!!!!
Well done @HannaOdud

jaymes15 · 2025-11-02T12:24:18Z

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

 // write one test at a time, and make it pass, build your solution up methodically
 // just make one change at a time -- don't rush -- programmers are deep and careful thinkers
 function getCardValue(card) {
+  let rank = card.slice(0, card.length-1) 


@HannaOdud Good use of slice() to get the part before the suit symbol!
A small improvement: you can write it as:
const rank = card.slice(0, -1);

reference:
https://www.w3schools.com/jsref/jsref_slice_string.asp

Thanks, I have changed it.

jaymes15 · 2025-11-02T12:25:14Z

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

  if (rank === "A") {
    return 11;
  }
+  else if ((parseInt(rank) >= 2 && parseInt(rank)) && parseInt(rank) < 11){


You’ve got the right idea here — checking for number cards.
A couple of tips to make it simpler and easier to read:

You don’t need to call parseInt several times — you can store it in a variable once.

You can also check if rank is a number using !isNaN(rank).

Thanks, I have changed it.

jaymes15 · 2025-11-02T12:26:22Z

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

+  else if ((parseInt(rank) >= 2 && parseInt(rank)) && parseInt(rank) < 11){
+    return parseInt(rank)
+  }
+  else if( rank === "J" || rank === "Q" || rank === "K") {


Nice work catching all the face cards!
Here’s a small tip: you can make this a bit cleaner by using an array:
else if (["J", "Q", "K"].includes(rank))

jaymes15 · 2025-11-02T12:26:50Z

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

+    return 10;
+  }
+  else{
+    throw  new Error("Invalid card rank.")


Excellent — throwing an error here makes sense.
Just small formatting notes:

Remove the extra space after throw.

Add a semicolon at the end.

Thanks, I've changed it.

jaymes15 · 2025-11-02T12:32:46Z

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

 // Then it should throw an error indicating "Invalid card rank."
+
+
+try {


You’re on the right track with try...catch, but assertEquals won’t run because the function throws an error first.
To actually test that an error happens, you can rewrite it like this:

try { getCardValue("W♥"); console.log("❌ Test failed: no error thrown"); } catch (error) { assertEquals(error.message, "Invalid card rank."); }

This way, you’re checking that the error message matches exactly what your function throws.

github-actions · 2025-11-02T12:57:36Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-02T12:57:36Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-03T21:45:09Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-03T21:45:09Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-09T11:05:31Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-09T11:05:32Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

HannaOdud added 3 commits October 25, 2025 15:18

Practicing test+Jest tests

6331dc0

Changes due to comments.

14d8bcb

Stretch

351cb9e

HannaOdud added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 28, 2025

jaymes15 added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 2, 2025

jaymes15 self-requested a review November 2, 2025 12:03

jaymes15 reviewed Nov 2, 2025

View reviewed changes

jaymes15 suggested changes Nov 2, 2025

View reviewed changes

jaymes15 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Nov 2, 2025

Some changes due to review.

2c63e1a

HannaOdud added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 3, 2025

jaymes15 approved these changes Nov 9, 2025

View reviewed changes

jaymes15 added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 9, 2025

		// Then it should throw an error indicating "Invalid card rank."


		try {

Uh oh!

Glasgow | 25-ITP-Sep | Hanna Mykytiuk | Sprint 3 | Stretch #816

Are you sure you want to change the base?

Glasgow | 25-ITP-Sep | Hanna Mykytiuk | Sprint 3 | Stretch #816

Uh oh!

Conversation

HannaOdud commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Questions

Uh oh!

github-actions bot commented Oct 28, 2025

Uh oh!

github-actions bot commented Oct 28, 2025

Uh oh!

github-actions bot commented Oct 28, 2025

Uh oh!

github-actions bot commented Nov 2, 2025

Uh oh!

github-actions bot commented Nov 2, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 2, 2025

Uh oh!

github-actions bot commented Nov 2, 2025

Uh oh!

github-actions bot commented Nov 3, 2025

Uh oh!

github-actions bot commented Nov 3, 2025

Uh oh!

github-actions bot commented Nov 9, 2025

Uh oh!

github-actions bot commented Nov 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

HannaOdud commented Oct 28, 2025 •

edited

Loading