Skip to content

London | 25-ITP-Sep | Payman Issa Baiglu | Sprint 1 | Coursework/sprint 1 #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
PaymanIB wants to merge 10 commits into
base: main
Choose a base branch
from
Open

London | 25-ITP-Sep | Payman Issa Baiglu | Sprint 1 | Coursework/sprint 1 #811

PaymanIB wants to merge 10 commits into from

Conversation

@PaymanIB
Copy link

@PaymanIB PaymanIB commented Oct 26, 2025 •
edited
Loading

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

in this PR: Sprint 1 Coursework completed. errors fixed and questions answered

@github-actions
Copy link

github-actions bot commented Oct 26, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

1 similar comment
@github-actions
Copy link

github-actions bot commented Oct 26, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@PaymanIB PaymanIB added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 26, 2025
cjyuan
cjyuan reviewed Oct 26, 2025
View reviewed changes
Sprint-1/1-key-exercises/3-paths.js
const ext = ;
const dir = filePath.slice(0, lastSlashIndex + 1);

const lastSlDotIndex = filePath.lastIndexOf(".");
Copy link
Contributor

@cjyuan cjyuan Oct 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the variable name, lastSlDotIndex, what does Sl stand for?

Copy link
Author

@PaymanIB PaymanIB Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it comes from Slice.

Copy link
Contributor

@cjyuan cjyuan Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable names should be meaningful. What are you trying to describe as SlDot? Slice dot?

Copy link
Author

@PaymanIB PaymanIB Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say it means the last slice after "."

Sprint-1/4-stretch-explore/chrome.md
What effect does calling the `prompt` function have?
A pop up window with the question and a place to input answer is opening.
What is the return value of `prompt`?
The input value will be returned by prompt() and stored in the variable myName.
Copy link
Contributor

@cjyuan cjyuan Oct 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if the user entered a value and clicked the "Cancel" button (instead of the "OK" button)?

Copy link
Author

@PaymanIB PaymanIB Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return value will be null for myName. meaning that no input.

Copy link
Contributor

@cjyuan cjyuan Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by "no input"?
What would prompt() return if the user didn't enter anything (i.e., no input) and then click "OK"?

Copy link
Author

@PaymanIB PaymanIB Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return will be null

Copy link
Author

@PaymanIB PaymanIB Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

null means no value entered.

Copy link
Contributor

@cjyuan cjyuan Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would prompt() return if the user didn't enter anything (i.e., no input) and then click "OK"?

Have you verified that prompt() returns null in this case? Because I got a different result.

Copy link
Author

@PaymanIB PaymanIB Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out. If cancel be clicked, the output will be null. If no value entered and OK be clicked the output will be nothing as ``.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 26, 2025
@PaymanIB
Copy link
Author

PaymanIB commented Oct 29, 2025

Many Thanks Cjyuan for reviewing this carefully. I do appreciate it!

@PaymanIB PaymanIB added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 29, 2025
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 29, 2025
@PaymanIB PaymanIB added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 29, 2025
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 29, 2025
@PaymanIB PaymanIB added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 29, 2025
@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 29, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Oct 29, 2025

All good. Well done.

@PaymanIB
Copy link
Author

PaymanIB commented Oct 30, 2025

Thanks for pointing out those details and helped me learn them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PaymanIB @cjyuan