West Midlands | 25-ITP-Sep | Baba Yusuf | Sprint 3 | coursework/sprint-3-implement-and-rewrite #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Baba05206 wants to merge 11 commits into CodeYourFuture:main from Baba05206:coursework/sprint-3-implement-and-rewrite

Baba05206 commented Oct 23, 2025 •

edited

Loading

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Updated functions and practiced test-driven development by adding test cases for the functions in the sprint-3 exercise.

Baba05206 added 8 commits

October 10, 2025 18:11


          checked npm install

c2ed214


          Implement angle type identification in getAngleType function

1c09d41


          Add validation for denominator and expand test cases in isProperFract…

7fd6b77

…ion function


          Implement card value calculation and error handling in getCardValue f…

068c792

…unction


          Refactor angle type tests for clarity and completeness

ed99cda


          Enhance test descriptions for isProperFraction function for clarity a…

…nd completeness


          Refactor tests for getCardValue function to enhance coverage and erro…

a18d6db

…r handling


          Refactor getCardValue function to improve error handling and support …

3975e54

…for numeric ranks

github-actions bot commented Oct 23, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

Baba05206 changed the title ~~Coursework/sprint-3-implement-and-rewrite~~ Birmingham | 25-ITP-Sep | Baba Yusuf| Sprint 1 | coursework/sprint-3-implement-and-rewrite

github-actions bot commented Oct 23, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

Baba05206 added 📅 Sprint 3 Needs Review labels

github-actions bot commented Oct 23, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

1 similar comment

github-actions bot commented Oct 23, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

Baba05206 changed the title ~~Birmingham | 25-ITP-Sep | Baba Yusuf| Sprint 1 | coursework/sprint-3-implement-and-rewrite~~ Birmingham | 25-ITP-Sep | Baba Yusuf | Sprint 1 | coursework/sprint-3-implement-and-rewrite

github-actions bot commented Oct 23, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

Baba05206 changed the title ~~Birmingham | 25-ITP-Sep | Baba Yusuf | Sprint 1 | coursework/sprint-3-implement-and-rewrite~~ Birmingham | 25-ITP-Sep | Baba Yusuf | Sprint 3 | coursework/sprint-3-implement-and-rewrite

github-actions bot commented Oct 23, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

Baba05206 changed the title ~~Birmingham | 25-ITP-Sep | Baba Yusuf | Sprint 3 | coursework/sprint-3-implement-and-rewrite~~ West Midlands | 25-ITP-Sep | Baba Yusuf | Sprint 3 | coursework/sprint-3-implement-and-rewrite

cjyuan added Review in progress and removed Needs Review labels

cjyuan reviewed

View reviewed changes

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js Outdated Show resolved Hide resolved

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js Outdated Show resolved Hide resolved

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js Show resolved Hide resolved

cjyuan added Reviewed and removed Review in progress labels

Baba05206 mentioned this pull request

25-ITP-Sep | Structuring and testing data | Baba Yusuf Baba05206/My-Coursework-Planner-BY#71

Open

Baba05206 added 2 commits

October 29, 2025 14:46


          chore: add package.json for Jest test setup in rewrite-tests-with-jest

e0d6ada


          Refactor getCardValue function to enhance handling of card ranks and …

30ac3b1

…improve error validation

Baba05206 added the Needs Review label

Contributor

cjyuan commented Oct 29, 2025

No new commits was pushed to GitHub.


          Refactor isProperFraction function to improve zero denominator handli…

debd986

…ng and simplify logic for proper fraction checks

Baba05206 added the Module-Structuring-And-Testing-Data label

cjyuan reviewed

View reviewed changes

Contributor

cjyuan left a comment

Changes look great. Well done.

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

Comment on lines +34 to +53

    
                expect(() => getCardValue("Z♠")).toThrow(

                  'Invalid or unrecognized card rank: "Z"'

                );

                expect(() => getCardValue("1♥")).toThrow(

                  'Invalid or unrecognized card rank: "1"'

                );

                expect(() => getCardValue("11♦")).toThrow(

                  'Invalid or unrecognized card rank: "11"'

                );

                expect(() => getCardValue("X♣")).toThrow(

                  'Invalid or unrecognized card rank: "X"'

                );

                // These should throw because they result in an empty or whitespace rank

                expect(() => getCardValue(" ♣")).toThrow(

                  'Invalid or unrecognized card rank: " "'

                );

                expect(() => getCardValue("♣")).toThrow(

                  'Invalid or unrecognized card rank: ""'

                );

Contributor

cjyuan Oct 29, 2025

If you have time, you could also explore using a loop+array or test.each() (https://jestjs.io/docs/api#testeachtablename-fn-timeout)

cjyuan added Complete and removed Needs Review Reviewed labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Module-Structuring-And-Testing-Data 📅 Sprint 3