Manchester | May 26 | Joanne O'Malley | Sprint 1 | Form Controls#922
Open
joanne342 wants to merge 2 commits intoCodeYourFuture:mainfrom
Open
Manchester | May 26 | Joanne O'Malley | Sprint 1 | Form Controls#922joanne342 wants to merge 2 commits intoCodeYourFuture:mainfrom
joanne342 wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
joanne342
added
Needs Review
joanne342
changed the title
joanne342
changed the title
joanne342
changed the title
joanne342
changed the title
joanne342
changed the title
joanne342
changed the title
joanne342
changed the title
Member
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
This looks great! There's one issue, which is that when I run lighthouse on this page, it has one problem. Can you take a look?
illicitonion
added
Reviewed
More space to improve Lighthouse score
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
joanne342
changed the title
This comment has been minimized.
This comment has been minimized.
Member
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
Author
|
Hello. Do I have permission to reopen it? I don't see the option anywhere. I didn't do it before because of having a full time job and 1.5-2hr commute and didn't even have time to turn my computer on during weekdays so I postponed ITP to May. Now I've figured out a shortcut to the train station (was taking the bus before) and can get home in an hour so I made the requested changes on this and changed Jan to May in the title. |
illicitonion
changed the title
joanne342
added
the
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Made an HTML-only form that take's the customer's name, email address and desired T-shirt colour and size.