Skip to content

Glasgow | ITP-Jan-2026 | Alasdair MacDonald | Sprint 1 | Wireframe#1070

Closed
MacDonald91 wants to merge 4 commits intoCodeYourFuture:mainfrom
MacDonald91:feature/wireframe
Closed

Glasgow | ITP-Jan-2026 | Alasdair MacDonald | Sprint 1 | Wireframe#1070
MacDonald91 wants to merge 4 commits intoCodeYourFuture:mainfrom
MacDonald91:feature/wireframe

Conversation

@MacDonald91
Copy link
Copy Markdown

Self-checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Completed all the steps. I also had issues with the first fork I created from the onboarding module; however, I have now solved this issue by creating a new fork and deleting the old content.

@MacDonald91 MacDonald91 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 26, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 26, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 3d2c289
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6997297e97d9e80008f61e2c
😎 Deploy Preview https://deploy-preview-1070--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@MacDonald91 MacDonald91 changed the title Glasgow | Jan-ITP-2026 | Alasdair MacDonald | Sprint 1 | Wireframe Glasgow | ITP-Jan-2026 | Alasdair MacDonald | Sprint 1 | Wireframe Jan 30, 2026
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • A well-prepared PR makes it easier for reviewers to approve it with minimal back-and-forth.
    Can you take a look at this General Feedback to see if there
    is anything you can do to make your PR more robust and ready?
    Doing so can help speed up the review process.

  • You would also need to edit the CSS code in style.css accordingly to produce the necessary page layout.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 4, 2026
@MacDonald91
Copy link
Copy Markdown
Author

Hi, sorry for the confusion. I had completed the task in my prior repo for this module. However, after much confusion i decided to delete the repo. I didn't realize that none of my work had saved locally and just submitted the work without checking anything.

My mistake, and I will make sure that I follow the steps and double-check that I've completed the steps for each task.

I believe I have now completed the requirements of this task.

@MacDonald91 MacDonald91 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 9, 2026
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • When a wireframe is provided, our implementation should closely reflect its appearance and layout to ensure consistency with design expectations. You're off to a solid start. To better align with the wireframe, can you

    • Center the PAGE TITLE and the "SHORT DESCRIPTION" beneath it on the page
    • Center the text on the footer
    • Place articles 2 and 3 side by side beneath article one.
  • According to https://validator.w3.org/, there is a warning in your code. Can you address it?

  • The footer content and the article content can overlap (see pic). Can you prevent it from happening while still keeping the footer fixed at the bottom of the viewport?

Image

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 9, 2026
@MacDonald91
Copy link
Copy Markdown
Author

Thank you for the feedback.

I have made the following improvements:

Removed trailing slashes from void elements to align with HTML5 standards and resolved the W3C validator warnings.

Removed the unnecessary

wrapper to address the "section lacks heading" warning.

Centered the page title and short description within the header.

Centered the footer content.

Adjusted the grid layout so that the first article spans the full width and articles two and three are positioned side by side beneath it.

Prevented footer overlap by adding appropriate bottom spacing while keeping the footer fixed to the bottom of the viewport.

The page now validates successfully via the W3C validator and more closely reflects the provided wireframe.

Please let me know if any further refinements are needed.

@MacDonald91 MacDonald91 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 19, 2026
…ust layout to match wireframe, and prevent footer overlap
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Feb 19, 2026

Changes look good. To better match the wireframe, can you align the image height between articles 2 and 3?

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 19, 2026
@MacDonald91
Copy link
Copy Markdown
Author

Thank you for the feedback.

I have now aligned the image heights between articles 2 and 3 to better match the intended wireframe layout and ensure visual consistency across the grid.

Please let me know if any further refinements are needed.

@MacDonald91 MacDonald91 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 19, 2026
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Feb 19, 2026

LGTM. Well done.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 19, 2026
@MacDonald91 MacDonald91 closed this May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants