Glasgow | ITP-Jan-2026 | Alasdair MacDonald | Sprint 1 | Wireframe#1070
Glasgow | ITP-Jan-2026 | Alasdair MacDonald | Sprint 1 | Wireframe#1070MacDonald91 wants to merge 4 commits intoCodeYourFuture:mainfrom
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cjyuan
left a comment
There was a problem hiding this comment.
-
A well-prepared PR makes it easier for reviewers to approve it with minimal back-and-forth.
Can you take a look at this General Feedback to see if there
is anything you can do to make your PR more robust and ready?
Doing so can help speed up the review process. -
You would also need to edit the CSS code in
style.cssaccordingly to produce the necessary page layout.
|
Hi, sorry for the confusion. I had completed the task in my prior repo for this module. However, after much confusion i decided to delete the repo. I didn't realize that none of my work had saved locally and just submitted the work without checking anything. My mistake, and I will make sure that I follow the steps and double-check that I've completed the steps for each task. I believe I have now completed the requirements of this task. |
cjyuan
left a comment
There was a problem hiding this comment.
-
When a wireframe is provided, our implementation should closely reflect its appearance and layout to ensure consistency with design expectations. You're off to a solid start. To better align with the wireframe, can you
- Center the PAGE TITLE and the "SHORT DESCRIPTION" beneath it on the page
- Center the text on the footer
- Place articles 2 and 3 side by side beneath article one.
-
According to https://validator.w3.org/, there is a warning in your code. Can you address it?
-
The footer content and the article content can overlap (see pic). Can you prevent it from happening while still keeping the footer fixed at the bottom of the viewport?
|
Thank you for the feedback. I have made the following improvements: Removed trailing slashes from void elements to align with HTML5 standards and resolved the W3C validator warnings. Removed the unnecessary Centered the page title and short description within the header. Centered the footer content. Adjusted the grid layout so that the first article spans the full width and articles two and three are positioned side by side beneath it. Prevented footer overlap by adding appropriate bottom spacing while keeping the footer fixed to the bottom of the viewport. The page now validates successfully via the W3C validator and more closely reflects the provided wireframe. Please let me know if any further refinements are needed. |
…ust layout to match wireframe, and prevent footer overlap
|
Changes look good. To better match the wireframe, can you align the image height between articles 2 and 3? |
|
Thank you for the feedback. I have now aligned the image heights between articles 2 and 3 to better match the intended wireframe layout and ensure visual consistency across the grid. Please let me know if any further refinements are needed. |
|
LGTM. Well done. |

Self-checklist
Changelist
Completed all the steps. I also had issues with the first fork I created from the onboarding module; however, I have now solved this issue by creating a new fork and deleting the old content.