-
-
Notifications
You must be signed in to change notification settings - Fork 283
London | 26-ATP-Jan | Boualem Larbi Djebbour | Sprint 3 | Quote generator #1200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
djebsoft
wants to merge
14
commits into
CodeYourFuture:main
Choose a base branch
from
djebsoft:quote-generator
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
2e93716
sorted out the head element
djebsoft 9426b56
adjusting the html title
djebsoft ca51b1e
implement the main function
djebsoft 99a7aa2
creating elements
djebsoft 3b6fe77
opleting the quote generator project.
djebsoft 0f8bf96
fixed the function to make the author match the quote
djebsoft db45069
rename main to setup
djebsoft e8f54ad
placing all the run on load code inside the setup function
djebsoft b22db66
separated JS code from HTML and used addEventListener()
djebsoft 35b34f7
take the event listener out of the setup function
djebsoft 570dca5
putting the click event listener inside a separate function for bette…
djebsoft fb9b865
calling the newQuote function Please enter the commit message for you…
djebsoft 2d49b11
renamed functions to be more descriptive.
djebsoft 69eab09
ade the setup function to perform the operations when the page loads.
djebsoft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,19 @@ | ||
| <!DOCTYPE html> | ||
| <!doctype html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Title here</title> | ||
| <title>Quote generator app</title> | ||
| <script defer src="quotes.js"></script> | ||
| <link rel="stylesheet" href="style.css" /> | ||
| </head> | ||
| <body> | ||
| <h1>hello there</h1> | ||
| <p id="quote"></p> | ||
| <p id="author"></p> | ||
| <button type="button" id="new-quote">New quote</button> | ||
| <body onload="main()"> | ||
| <div class="container"> | ||
| <p id="quote"></p> | ||
| <p id="author"></p> | ||
| <div id="new-quote"> | ||
| <button type="button">New quote</button> | ||
| </div> | ||
| </div> | ||
| </body> | ||
| </html> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,43 @@ | ||
| /** Write your CSS in here **/ | ||
| body { | ||
| background-color: orange; | ||
| display: flex; | ||
| justify-content: center; | ||
| align-items: center; | ||
| height: 100vh; | ||
| } | ||
| .container { | ||
| background-color: white; | ||
| width: 60%; | ||
| padding: 50px 50px; | ||
| } | ||
| #quote { | ||
| text-align: center; | ||
| color: orange; | ||
| font-size: 28px; | ||
| } | ||
| #quote::before { | ||
| content: open-quote; | ||
| } | ||
| #quote::after { | ||
| content: close-quote; | ||
| } | ||
| #author { | ||
| color: orange; | ||
| text-align: right; | ||
| font-size: 20px; | ||
| } | ||
| #author::before { | ||
| content: "- "; | ||
| } | ||
| #new-quote { | ||
| display: flex; | ||
| justify-content: end; | ||
| } | ||
| button { | ||
| background-color: orange; | ||
| color: white; | ||
| border: none; | ||
| font-size: 18px; | ||
| padding: 15px; | ||
| cursor: pointer; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.