Manchester | 26-ITP-Jan | Mehroz Munir | Sprint 2| Book Library#433
Open
MehrozMunir wants to merge 1 commit intoCodeYourFuture:mainfrom
Open
Manchester | 26-ITP-Jan | Mehroz Munir | Sprint 2| Book Library#433MehrozMunir wants to merge 1 commit intoCodeYourFuture:mainfrom
MehrozMunir wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
MehrozMunir
added
📅 Sprint 2
cjyuan
reviewed
Apr 16, 2026
Contributor
There was a problem hiding this comment.
According to https://validator.w3.org/, there is an error in your index.html. Can you fix it?
| @@ -1,14 +1,13 @@ | |||
| let myLibrary = []; | |||
Contributor
There was a problem hiding this comment.
Could consider declaring it using const.
| const book = new Book( | ||
| titleInput.value, | ||
| authorInput.value, | ||
| pagesInput.value, |
Contributor
There was a problem hiding this comment.
.value is a string, and a user can enter a value such as "1.4e2" (a numerical value equals to 140) in the input field.
| readStatus = "No"; | ||
| } | ||
| changeBut.innerText = readStatus; | ||
| myLibrary[i].check ? (readStatus = "Yes") : (readStatus = "No"); |
Contributor
There was a problem hiding this comment.
Normally way to use ? : is:
readStatus = myLibrary[i].check ? "Yes" : "No";
condition ? v1 : v2 is an expression. It evaluates to v1 if condition is true, and to v2 if condition is false.
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I have tried to make the book library website more interactive, added validation for the input fields, and resolved the bugs in rendering and adding data.