WestMidlands | 26-SDC-Mar | Chioma Okeke | Sprint 1 | Analyse and Refactor Functions#179
Open
JanefrancessC wants to merge 4 commits into
Open
WestMidlands | 26-SDC-Mar | Chioma Okeke | Sprint 1 | Analyse and Refactor Functions#179JanefrancessC wants to merge 4 commits into
JanefrancessC wants to merge 4 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
JanefrancessC
added
📅 Sprint 1
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
JanefrancessC
changed the title
This comment has been minimized.
This comment has been minimized.
JanefrancessC
added
the
Needs Review
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
JanefrancessC
changed the title
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
JanefrancessC
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
JanefrancessC
changed the title
JanefrancessC
added
the
Needs Review
cjyuan
reviewed
Jun 25, 2026
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Both code and complexity analysis are good. Well done.
Comment on lines
+18
to
+20
| const secondSet = new Set(secondArray); | ||
|
|
||
| return [...new Set(firstArray.filter((item) => secondSet.has(item)))]; |
There was a problem hiding this comment.
Could also take advantage of Set's built-in methods to find common items between two sets.
Comment on lines
+15
to
20
| for (const item of inputSequence) { | ||
| if (!seenItems.has(item)) { | ||
| seenItems.add(item); | ||
| result.push(item); | ||
| } | ||
| } |
There was a problem hiding this comment.
Could also take advantage of how Set and Array could be converted from one another to simplify the code.
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Refactor and analyse functions based on Time and Space complexities.