NW | 26-SDC-Mar | TzeMing Ho | Sprint 2 | implement_lru_cache#169
Open
TzeMingHo wants to merge 2 commits into
Open
NW | 26-SDC-Mar | TzeMing Ho | Sprint 2 | implement_lru_cache#169TzeMingHo wants to merge 2 commits into
TzeMingHo wants to merge 2 commits into
Conversation
TzeMingHo
added
📅 Sprint 2
cjyuan
reviewed
Jun 18, 2026
| def set(self, key, value): | ||
| if key in self.dict: | ||
| self.dict[key].value = value | ||
| self.get(key) |
There was a problem hiding this comment.
With the current approach of moving a node to the front:
- It is not immediately obvious why this method calls
get() - Calling
get()introduces an additional (but unnecessary) dictionary lookup
Could you explore a cleaner way to structure the code?
cjyuan
added
Reviewed
TzeMingHo
added
Needs Review
cjyuan
reviewed
Jun 21, 2026
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Have you also looked up "Best practices about using __slot__" to learn more about it?
Changes look good. Well done.
Comment on lines
+4
to
+6
| def __init__(self, key, value): | ||
| self.key = key | ||
| self.value = value |
There was a problem hiding this comment.
Making each node to keep two values (key and value) would make the linked list less attractive (because most uses of linked list only needs to store one value in each node).
Could you describe how you would implement the LRU cache if you were to import your linked list implemented in the other exercise (unmodified)?
No change needed
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
1.1 Accepts a key, a value in the class Node
1.2 Methods in class LinkedList accept Node