Skip to content

CTPD-4358 Make health probe path port configurable in codetogether-intel helm chart#208

Merged
danc094codetogether merged 1 commit intodevfrom
CTPD-4358-make-health-probe-path-port-configurable-in-codetogether-intel-helm-chart
Apr 9, 2026
Merged

CTPD-4358 Make health probe path port configurable in codetogether-intel helm chart#208
danc094codetogether merged 1 commit intodevfrom
CTPD-4358-make-health-probe-path-port-configurable-in-codetogether-intel-helm-chart

Conversation

@danc094codetogether
Copy link
Copy Markdown
Contributor

@danc094codetogether danc094codetogether commented Apr 9, 2026

Summary

  • Templates the hardcoded path: / and port: http in liveness and readiness probes in deployment.yaml so they can be overridden via values.yaml.
  • Adds path and port fields to both probe blocks in values.yaml with backward-compatible defaults (/ and http).
  • Bumps chart version from 1.3.4 to 1.3.5.

Why

The SaaS staging deployment needs probes at /actuator/health and /actuator/health/readiness on port 8080, but the chart ignored these values because the paths and ports were hardcoded.

Safety

  • Existing customers on 1.3.4 are completely untouched.
  • Customers upgrading to 1.3.5 without setting path/port get identical behavior due to defaults.
  • Only deployments that explicitly override path and port get different probe behavior.

CTPD-4358

Template the hardcoded path (/) and port (http) in liveness and
readiness probes so they can be overridden via values. Defaults
preserve existing behavior for all current deployments.

CTPD-4358

Made-with: Cursor
@danc094codetogether danc094codetogether changed the title feat: make health probe path/port configurable (v1.3.5) CTPD-4358 Make health probe path port configurable in codetogether-intel helm chart Apr 9, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the codetogether-intel Helm chart to make liveness/readiness probe httpGet.path and httpGet.port configurable via values.yaml, addressing deployments that need non-root health endpoints and/or non-default ports.

Changes:

  • Add path and port fields to readinessProbe and livenessProbe in values.yaml with backward-compatible defaults.
  • Template httpGet.path and httpGet.port in templates/deployment.yaml using the new values (with defaults).
  • Bump chart version from 1.3.4 to 1.3.5.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
charts/intel/values.yaml Adds configurable path/port fields for readiness/liveness probes with defaults.
charts/intel/templates/deployment.yaml Wires probe httpGet.path/port to .Values.*Probe.{path,port}.
charts/intel/Chart.yaml Increments chart version to 1.3.5.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@danc094codetogether danc094codetogether merged commit 673c1e1 into dev Apr 9, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants