CTPD-4358 Make health probe path port configurable in codetogether-intel helm chart#208
Merged
danc094codetogether merged 1 commit intodevfrom Apr 9, 2026
Conversation
Template the hardcoded path (/) and port (http) in liveness and readiness probes so they can be overridden via values. Defaults preserve existing behavior for all current deployments. CTPD-4358 Made-with: Cursor
There was a problem hiding this comment.
Pull request overview
This PR updates the codetogether-intel Helm chart to make liveness/readiness probe httpGet.path and httpGet.port configurable via values.yaml, addressing deployments that need non-root health endpoints and/or non-default ports.
Changes:
- Add
pathandportfields toreadinessProbeandlivenessProbeinvalues.yamlwith backward-compatible defaults. - Template
httpGet.pathandhttpGet.portintemplates/deployment.yamlusing the new values (with defaults). - Bump chart version from
1.3.4to1.3.5.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| charts/intel/values.yaml | Adds configurable path/port fields for readiness/liveness probes with defaults. |
| charts/intel/templates/deployment.yaml | Wires probe httpGet.path/port to .Values.*Probe.{path,port}. |
| charts/intel/Chart.yaml | Increments chart version to 1.3.5. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
golfingal72
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
path: /andport: httpin liveness and readiness probes indeployment.yamlso they can be overridden viavalues.yaml.pathandportfields to both probe blocks invalues.yamlwith backward-compatible defaults (/andhttp).1.3.4to1.3.5.Why
The SaaS staging deployment needs probes at
/actuator/healthand/actuator/health/readinesson port8080, but the chart ignored these values because the paths and ports were hardcoded.Safety
path/portget identical behavior due to defaults.pathandportget different probe behavior.CTPD-4358