Skip to content

feat: add family sharing integration#27

Merged
CodeKeanu merged 3 commits into
mainfrom
feature/issue-10-family-sharing
Dec 12, 2025
Merged

feat: add family sharing integration#27
CodeKeanu merged 3 commits into
mainfrom
feature/issue-10-family-sharing

Conversation

@CodeKeanu
Copy link
Copy Markdown
Owner

Summary

  • Add get_family_group tool to get family group membership information (members, roles, cooldown status, available slots)
  • Add get_shared_library_apps tool to get games available through family sharing (grouped by owner, with exclusion reasons)
  • Graceful handling for users not in a family group or with private profiles
  • 14 unit tests with mocked responses

Changes

  • New endpoint module: src/steam_mcp/endpoints/family_groups.py
  • New test file: tests/test_family_groups.py
  • Updated README (30 -> 32 tools)
  • Updated CHANGELOG

Testing

  • All existing tests pass (201 tests)
  • New functionality tested with 14 unit tests

Checklist from Issue

  • Family group membership retrieval
  • Shared library listing with availability
  • Graceful handling for non-family members
  • Unit tests with mocked responses
  • README and CHANGELOG updated

Closes #10

🤖 Generated with Claude Code

- Add IFamilyGroupsService endpoint module with 2 tools:
  - get_family_group: Get family group membership, members, and roles
  - get_shared_library_apps: Get games available through family sharing
- Include 14 unit tests with mocked responses
- Update README (30 -> 32 tools) and CHANGELOG

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@CodeKeanu
Copy link
Copy Markdown
Owner Author

Code Review - Family Sharing Integration

Verdict: ✅ Approve

Strengths:

  • Comprehensive test coverage (314 lines)
  • Clean grouping logic for shared apps
  • Proper 401/403 error handling

Suggestions (non-blocking):

  • _resolve_steam_id() duplicated across 5 endpoint files - recommend follow-up issue to extract to BaseEndpoint
  • owner_apps[:10] hardcoded - consider making configurable

Review by @agent-ml-python-mcp-expert

CodeKeanu and others added 2 commits December 12, 2025 09:00
Moves the shared _resolve_steam_id method from individual endpoint
classes to BaseEndpoint, reducing code duplication across 5 files.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@CodeKeanu CodeKeanu merged commit 4ad2e6a into main Dec 12, 2025
1 check passed
@CodeKeanu CodeKeanu deleted the feature/issue-10-family-sharing branch December 12, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Family Sharing Integration

1 participant