Skip to content

Conversation

@gezaldo
Copy link

@gezaldo gezaldo commented Oct 16, 2018

Description:

Description of your changes.
og:type
New imports / dependencies:

  • package

Unit Tests:

  • apps/volontulo/tests/views/test_auth.py

What tests do I need to run to validate this change:

Description of testing workflow and potential affected places.

Copy link
Member

@magul magul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gezaldo, Thank You for your contribution here.

There's an issue with that change, that what You suggest is not a valid TypeScript code.

I attached proper one in inline comment.

// set default tags, that will be orverwritten below:
this.metaService.updateTag({ property: 'og:url', content: this.getCanonicalUrl(this.locationService.path()) });
this.metaService.updateTag({ property: 'og:title', content: 'Volontulo. Portal dla wolontariuszy' });
this.metaService.updateTag({ property:= 'og:type' content:"website"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

    this.metaService.updateTag({ property: 'og:type'  content:"website" });

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants