[1070] Add img to organization #1071
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
magul
requested changes
Sep 29, 2018
frontend/src/app/metatags.service.ts
Outdated
| this.metaService.updateTag({ property: 'og:description', content: 'Volontulo. Portal dla wolontariuszy'}); | ||
| this.metaService.updateTag({ property: 'og:image', content: this.getCanonicalUrl('/assets/img/banner/volontulo_baner.png') }); | ||
| this.metaService.updateTag({ property: 'fb:app_id', content: environment.fbAppID }); | ||
| this.metaService.updateTag({ name: 'og:url', content: this.getCanonicalUrl(this.locationService.path()) }); |
Member
There was a problem hiding this comment.
These metatags should have property defined, not name (see: https://developers.facebook.com/docs/sharing/webmasters/). It was fixed in #1061. Does here merge went wrong?
| @@ -1,4 +1,8 @@ | |||
| <div class="container"> | |||
| <div class="card bg-light mb-3 text-white"> | |||
Member
There was a problem hiding this comment.
The whole point of this change was to introduce solution, that will work without any changes when backend API will be developed. You can use loadDefaultImage the way how @juliaanholcer developed it for offerrs or suggest your own solution, but it should be already here, when backend will arrive.
Contributor
Author
There was a problem hiding this comment.
loadDefaultImage is only for offer, should I make other function for organization?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added img to organizations. For now it's volontulo img -waiting for backend to change to this.organization img.