Skip to content

Conversation

@dianawieczorek
Copy link
Contributor

Description:

Form show a message that date of recriutment can't be set after action is finished. Offer with wrong dates cannot be saved in database.

@dianawieczorek
Copy link
Contributor Author

#726

@codecov-io
Copy link

codecov-io commented Aug 8, 2018

Codecov Report

Merging #1041 into master will decrease coverage by 0.62%.
The diff coverage is 7.4%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1041      +/-   ##
==========================================
- Coverage   91.52%   90.89%   -0.63%     
==========================================
  Files         119      119              
  Lines        2901     2922      +21     
  Branches       31       41      +10     
==========================================
+ Hits         2655     2656       +1     
- Misses        242      252      +10     
- Partials        4       14      +10
Impacted Files Coverage Δ
frontend/src/app/services/metatags.service.ts 47.61% <0%> (ø) ⬆️
...ents/offers/create-offer/create-offer.component.ts 43% <9.09%> (-10.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28f2734...2c63d25. Read the comment docs.

Copy link
Member

@magul magul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

}

.form-text{
font-size: .875rem
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should end with semicolon

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@dianawieczorek
Copy link
Contributor Author

Backend issue here #1094

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants