Redo game show page #124
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,97 +1,105 @@ | ||
| <div class ="game-show"> | ||
| <div class="container-fluid"> | ||
| <div class="row"> | ||
| <div class="col-md-6 col-sm-6"> | ||
| <h2 style="font-weight:bold; margin-bottom: 20px; color: #EF7030;"><%= @game.title %></h2> | ||
|
Contributor
There was a problem hiding this comment. Avoid inlining styles. Can put this in a class? You could use a selector such as |
||
| <p><%= @game.description %></p> | ||
| <!-- game management begins --> | ||
| <% if (user_is_dev? && @game.user_id == current_user.id ) || | ||
| user_is_admin? %> | ||
| <p>Type: | ||
| <% @game.taggings.map do |tagging| %> | ||
| <%= Tag.find(tagging.tag_id).name %> | | ||
| <% end %> | ||
| </p> | ||
| <div class="container-fluid" style="background-color: steelblue"> | ||
| <%# if can?(:manage, @game) %> | ||
|
Contributor
There was a problem hiding this comment. Can you delete this line?
Contributor
There was a problem hiding this comment. Can you delete this line? |
||
| <% if user_is_admin? || | ||
| ( user_is_dev? && @game.user_id == current_user.id) %> | ||
| <div class="radiolist"> | ||
| <%= simple_form_for(@game) do |f| %> | ||
| <%= f.error_notification %> | ||
| <p> | ||
| <%= link_to "Download Game", @game.download_button, class: "btn btn-default" %> | ||
| <% if @game.may_approve? %> | ||
| <%= f.button :submit, Game::STATE_APPROVE, value: "Approve Game" %> | ||
|
Contributor
There was a problem hiding this comment. This should be indented one more level. |
||
| <% end %> | ||
| <% if @game.may_reject? %> | ||
| <%= f.button :submit, Game::STATE_REJECT, value: "Reject Game" %> | ||
|
|
||
| <% end %> | ||
| </p> | ||
| <% end %> | ||
| </div> | ||
| <% end %> | ||
| <%# if (can? :manage, @game ) %> | ||
|
Contributor
There was a problem hiding this comment. Delete this one too. It's not used 😎
Contributor
There was a problem hiding this comment. Delete me! I no longer have purpose in life. 😨 |
||
|
|
||
| <div> | ||
| <p> | ||
| <%= link_to "Download Pdf", game_review_path(@game.id), class:"btn btn-default" %> | ||
|
Contributor
There was a problem hiding this comment.
|
||
| <%= link_to "Download Game", @game.attachment_url, class:"btn btn-default" %> | ||
| <%= link_to "Download Crash", href="#", class:"btn btn-default" %> | ||
| </p> | ||
| </div> | ||
| </div> | ||
| <% end %> | ||
| </div> | ||
|
Contributor
There was a problem hiding this comment. The indent level on this closing div isn't quite right. |
||
| <!-- end of game management --> | ||
| <div class="col-md-6 col-sm-6"> | ||
|
Contributor
There was a problem hiding this comment. Is this div used at all? Please fix the indenting. 🤓 |
||
| <!-- image carousel begins --> | ||
| <div> | ||
| <div id="home-slideshow" class="carousel slide" data-ride="carousel"> | ||
| <ol class="carousel-indicators"> | ||
|
|
||
| <% @game.pictures.each_with_index do |pic, i| %> | ||
| <li data-target="#home-slideshow" data-slide-to= <%= "#{i}" %> | ||
|
Contributor
There was a problem hiding this comment. Remove the space after |
||
| <% if i == 0 %> | ||
| class="active"> | ||
| <% else %> | ||
| > | ||
| <% end %> | ||
| </li> | ||
| <% end %> | ||
| </ol> | ||
| <div class="carousel-inner" role="listbox"> | ||
| <% @game.pictures.each_with_index do |picture, index| %> | ||
| <% url = picture.carousel.url %> | ||
| <% if index == 0 %> | ||
| <div class="item active"> | ||
|
Contributor
There was a problem hiding this comment. Indenting should be two spaces |
||
| <%= image_tag url, class: "carousel-image" %> | ||
| </div> | ||
| <% else %> | ||
| <div class="item"> | ||
| <%= image_tag url, class: "carousel-image" %> | ||
| </div> | ||
| <% end %> | ||
| <% end %> | ||
| </div> | ||
| </div> | ||
|
|
||
| </div> | ||
|
|
||
| <!-- end of image carousel --> | ||
| <div> | ||
| <!-- game stats begin --> | ||
|
|
||
| <p class="char1">Made by: <%= @game.user_company %></p> | ||
| <p>Date: <%= @game.formatted_created_at %></p> | ||
| <p>Type: <%= @game.type_display %></p> | ||
| <p>Last in Arcade: <%= @game.last_in_arcade %></p> | ||
| <p>Played: <%= @game.reviews_count %> times</p> | ||
| <p>Overall Rating: <%= @game.reviews_count %></p> | ||
| <!-- end of game stats --> | ||
| <% if user_is_gamer? %> | ||
| <div> | ||
|
Contributor
There was a problem hiding this comment. Too much indenting here. |
||
| <%= button_to "Buy", @game.link, class:"btn btn-default" %> | ||
| </div> | ||
| <% end %> | ||
|
|
||
| <div class="container"> | ||
| <!-- <div class="back-btn-update"><%= button_to "Back", games_path, class:"orange" %></div> --> | ||
| </div> | ||
| </div> | ||
|
|
||
| </div> | ||
| </div> | ||
| </div> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the space between
class =? Bridge the divide! ✊