Skip to content

Fix Expired Chain Doesn't Rotate on Successful Login #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mckaragoz merged 1 commit into from
May 10, 2026
Merged

Fix Expired Chain Doesn't Rotate on Successful Login #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified samples/blazor-server/CodeBeam.UltimateAuth.Sample.BlazorServer.EFCore/uauth.db-shm
View file
Open in desktop
Binary file not shown.
Binary file modified samples/blazor-server/CodeBeam.UltimateAuth.Sample.BlazorServer.EFCore/uauth.db-wal
View file
Open in desktop
Binary file not shown.
11 changes: 9 additions & 2 deletions src/CodeBeam.UltimateAuth.Server/Flows/Login/LoginOrchestrator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,15 @@ public async Task<LoginResult> LoginAsync(AuthFlowContext flow, LoginRequest req
{
var chain = await sessionStore.GetChainByDeviceAsync(userKey.Value, deviceId, ct);

if (chain is not null && !chain.IsRevoked)
chainId = chain.ChainId;
if (chain is not null)
{
var chainState = chain.GetState(now, _options.Session.IdleTimeout);

if (chainState == SessionState.Active)
{
chainId = chain.ChainId;
}
}
}

// TODO: Add accountState here, currently it only checks factor state
Expand Down
9 changes: 7 additions & 2 deletions src/CodeBeam.UltimateAuth.Server/Infrastructure/Issuers/UAuthSessionIssuer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,13 @@ await kernel.ExecuteAsync(async _ =>
//chain = await kernel.GetChainAsync(context.ChainId.Value)
// ?? throw new UAuthNotFoundException("Chain not found.");

if (chain.IsRevoked)
throw new UAuthValidationException("Chain revoked.");
var chainState = chain.GetState(now, _options.Session.IdleTimeout);

if (chainState != SessionState.Active)
throw new UAuthValidationException("Chain is not active.");

//if (chain.IsRevoked)
// throw new UAuthValidationException("Chain revoked.");

if (chain.UserKey != context.UserKey || chain.Tenant != context.Tenant)
throw new UAuthValidationException("Invalid chain ownership.");
Expand Down
Loading