Fixed api compatibility issues:#7
Open
misterbobdobalina wants to merge 1 commit intoCodeAndMagic:masterfrom
Open
Fixed api compatibility issues:#7misterbobdobalina wants to merge 1 commit intoCodeAndMagic:masterfrom
misterbobdobalina wants to merge 1 commit intoCodeAndMagic:masterfrom
Conversation
android:minSdkVersion="8"
android:targetSdkVersion="19"
However,
TargetApi wasn't introduced until api level 16,
which won't work with api level 8 as above.
Same with:
Build.VERSION_CODES.HONEYCOMB added in api level 11
View.LAYER_TYPE_SOFTWARE added in api level 11
Replaced them with their constant values instead.
I have verified that it works on api level 14. It won't compile
otherwise.
Finally:
readRanges() never uses its input parameters in:
private void readRanges(final Resources res, final int rangesId, final int colorsId)
if (rangesId > 0 && colorsId > 0) {
final String[] ranges = res.getStringArray(R.array.ranges);
final String[] colors = res.getStringArray(R.array.rangeColors)
...
Changed it so that it uses rangesId and colorsId instead.
I have tried this as an apklib an it workds. It was incorrect as
it was before, because it wouldn't reference the correct resources
if I remember correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed api compatibility issues:
android:minSdkVersion="8"
android:targetSdkVersion="19"
However,
TargetApi wasn't introduced until api level 16,
which won't work with api level 8 as above.
Same with:
Build.VERSION_CODES.HONEYCOMB added in api level 11
View.LAYER_TYPE_SOFTWARE added in api level 11
Replaced them with their constant values instead.
I have verified that it works on api level 14. It won't compile
otherwise.
Finally:
readRanges() never uses its input parameters in:
private void readRanges(final Resources res, final int rangesId, final int colorsId)
Changed it so that it uses rangesId and colorsId instead.
I have tried this as an apklib an it workds. It was incorrect as
it was before, because it wouldn't reference the correct resources
if I remember correctly.