-
Notifications
You must be signed in to change notification settings - Fork 77
Feature/loading state login signup #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/loading state login signup #143
Conversation
✅ Deploy Preview for paisable ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a loading state to the Login and Register flows to improve UX by disabling the submit button and showing “Loading...” during in-flight requests.
- Introduces a loading state per page to prevent multiple submissions
- Updates button UI/behavior based on loading and reformats JSX/strings for consistency
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| frontend/src/pages/RegisterPage.jsx | Adds loading state, disables submit button, and shows “Loading...”, plus formatting updates. |
| frontend/src/pages/LoginPage.jsx | Adds loading state, disables submit button, and shows “Loading...”, plus formatting updates. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Hey @Avdhesh-Varshney @archa8 👋 |
archa8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly discard all the changes that change '' to "" in the RegisterPage.jsx as these are redundant and unnecessary. Just the imports and usages in that page are fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Discarded all redundant changes from single quotes to double quotes in RegisterPage.jsx. Kept only the imports and functional code as required. |
|
@archa8 please close the pr if it is of no use. |
|
Hi @govindmehta Where you logic for loading state?
|
|
@Avdhesh-Varshney i wrote the logic, a day before then when i went to merge archa8 already made those changes plus some ui changes, so my logic was redundant. So its basically of no use, as one of the maintainers already did it. I raised the issue but you guys already did it even after assigning it to me. |
|
@govindmehta, I merged another PR which enhanced the Login and Signup pages, which already had the 'Signing up' and 'Logging in' loading state written by the contributor. This was after I reviewed your PR for the first time, but now that I have already merged PR #136 this PR cannot be merged as well as the |

What I did
isLoading) to Login and Signup pages.How to test
Fixes #140

