Skip to content

Conversation

@govindmehta
Copy link

What I did

  • Added loading state (isLoading) to Login and Signup pages.
  • Disabled submit button during API call.
  • Changed button text to show "Loading..." for better UX.
  • Prevented multiple clicks and improved responsiveness.

How to test

  1. Click Login or Create Account.
  2. Button changes to “Loading...” and is disabled temporarily.

Fixes #140
p2
p1

Copilot AI review requested due to automatic review settings October 20, 2025 08:46
@netlify
Copy link

netlify bot commented Oct 20, 2025

Deploy Preview for paisable ready!

Name Link
🔨 Latest commit b638021
🔍 Latest deploy log https://app.netlify.com/projects/paisable/deploys/68f604bc46ae7a00082e44c5
😎 Deploy Preview https://deploy-preview-143--paisable.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 94
Accessibility: 100
Best Practices: 100
SEO: 91
PWA: 80
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a loading state to the Login and Register flows to improve UX by disabling the submit button and showing “Loading...” during in-flight requests.

  • Introduces a loading state per page to prevent multiple submissions
  • Updates button UI/behavior based on loading and reformats JSX/strings for consistency

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
frontend/src/pages/RegisterPage.jsx Adds loading state, disables submit button, and shows “Loading...”, plus formatting updates.
frontend/src/pages/LoginPage.jsx Adds loading state, disables submit button, and shows “Loading...”, plus formatting updates.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@govindmehta
Copy link
Author

Hey @Avdhesh-Varshney @archa8 👋
I’ve resolved the merge conflicts — PR is updated and ready for review. 😊

Copy link
Member

@archa8 archa8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly discard all the changes that change '' to "" in the RegisterPage.jsx as these are redundant and unnecessary. Just the imports and usages in that page are fine.

Copilot AI review requested due to automatic review settings October 20, 2025 09:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@govindmehta
Copy link
Author

govindmehta commented Oct 20, 2025

Discarded all redundant changes from single quotes to double quotes in RegisterPage.jsx. Kept only the imports and functional code as required.
@archa8

@govindmehta govindmehta requested a review from archa8 October 20, 2025 09:56
@govindmehta
Copy link
Author

@archa8 please close the pr if it is of no use.

@govindmehta govindmehta reopened this Oct 21, 2025
@Avdhesh-Varshney
Copy link
Member

Hi @govindmehta Where you logic for loading state?

Don't use prettier for formatting, right now

@govindmehta
Copy link
Author

@Avdhesh-Varshney i wrote the logic, a day before then when i went to merge archa8 already made those changes plus some ui changes, so my logic was redundant. So its basically of no use, as one of the maintainers already did it. I raised the issue but you guys already did it even after assigning it to me.

@archa8
Copy link
Member

archa8 commented Oct 21, 2025

@govindmehta, I merged another PR which enhanced the Login and Signup pages, which already had the 'Signing up' and 'Logging in' loading state written by the contributor. This was after I reviewed your PR for the first time, but now that I have already merged PR #136 this PR cannot be merged as well as the hacktoberfest-accpeted label cannot be assigned to this as you deleted the core logic for your PR from the code. Thank you

@archa8 archa8 closed this Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing: Add Loading state at the Login/Signup

3 participants