fix: add dynamic greeting variations to make Jarvis feel more natural #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE. |
- Created GetRandomWelcomeMessage function in greeting.py with 10 different greeting variations - Updated auth.py to use random greetings instead of static message - Includes original greeting message plus 9 new variations - All changes pass ruff linting checks Closes Code-A2Z#327
Om7035
force-pushed
the
fix/dynamic-greeting-327
branch
from
785bba5 to
f11da40
Compare
Contributor
Author
|
@Avdhesh-Varshney can you take a look at this and review the PR and let me know any changes you want in it also let me know any suggestions on it |
Avdhesh-Varshney
added
hacktoberfest-accepted
level1
onlydust-wave
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #327
Describe the add-ons or changes you've made 📃
Fixed the repetitive greeting issue by implementing dynamic greeting variations. Now Jarvis randomly selects from 10 different welcome messages instead of always showing the same "Welcome to Jarvis AI Assistant!" message.
Changes:
This makes Jarvis feel more dynamic, natural, and less robotic as requested in the issue.
Working Video 📷
[You'll need to record a video showing the authentication page with different greetings appearing on refresh]
Type of change ☑️
Note to reviewers 📄