-
Notifications
You must be signed in to change notification settings - Fork 200
Adding Arabic Dates Classification using DL #329 #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE. |
|
@Avdhesh-Varshney |
Avdhesh-Varshney
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
For GitHub Lint error, It's due to you have not formatted your file in 2-space indentation. Please update this to 2-space.
For any blocker, connect me on discord or ping me here 👍
src/apps/pages/models/ImageProcessing/ArabicDatesClassifierModel.py
Outdated
Show resolved
Hide resolved
|
One more thing — I need a video demonstrating that your model is fully integrated with Jarvis, as your file still requires following some additional setup steps. |
|
@SupratikB23 Could you please gone through the movie recommendations model already integrated in Jarvis? |
|
@Avdhesh-Varshney |
|
https://github.com/Code-A2Z/jarvis/wiki/Jarvis-Authentication-System Check this will help you |
|
Yes done checks with AUTH (video attached), also have made the file to 2-space indentation format. Arabic.Dates.Classification.with.Auth.2.mp4 |
Avdhesh-Varshney
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect 🎉
Thanks for your contribution!
Closes: #329
Describe the add-ons or changes you've made 📃
Working Video 📷
Arabic.Dates.Classification.mp4