Jx/ssf 202 dashboard stats#183
Conversation
jiang-h-y
left a comment
jiang-h-y
left a comment
There was a problem hiding this comment.
Pantry, admin, and volunteer stats look good.
Similarly to the empty state ticket, might want to wait until the FM dashboard is merged.
|
@jxuistrying btw - justin's FM dashboard pr has been merged! could you add the stats for FM dashboards~ |
Yurika-Kan
left a comment
Yurika-Kan
left a comment
There was a problem hiding this comment.
left comments regarding cleaning the pr, simplifying implementation, and a design bug!
- pls add fmdashboard to this pr as well :)
| foodRescue?: boolean; | ||
| } | ||
|
|
||
| export interface AdminVolunteerStats { |
There was a problem hiding this comment.
these types already exist as their own dtos when the backend was done~ so these con't need to be in here!
take a look as [users.controller.ts:43] where it wires all 3 stat dtos
There was a problem hiding this comment.
pls remove these duplicate files / changes of your other pr!
| /> | ||
| ))} | ||
| </Box> | ||
| {stats && <DashboardStats stats={stats} />} |
There was a problem hiding this comment.
could you investigate the frontend component and align the leftmost & rightmost (edges) of the top stat cards with the leftmost & rightmost of the bottom action cards?
vs our current version:
3 participants
ℹ️ Issue
Closes #202
📝 Description
Write a short summary of what you added. Why is it important? Any member of C4C should be able to read this and understand your contribution -- not just your team members.
I connected frontend ui to stats endpoint to display top 4 stats on dashboards
Briefly list the changes made to the code:
✔️ Verification
logged in with admin and volunteer accounts to check that the stats is displayed on the dashboard
🏕️ (Optional) Future Work / Notes
I couldn't log in as a valid pantry user still so I still have to check if the pantry stats is displayed but the stats should be working