Allow codspeed runner to run outside of a git directory#74
Merged
GuillaumeLagrange merged 2 commits intomainfrom Mar 31, 2025
Merged
Conversation
not-matthias
approved these changes
Mar 27, 2025
Member
not-matthias
left a comment
not-matthias
left a comment
There was a problem hiding this comment.
Overall very nice, I'd only consider changing the log_json to use structured logging. Or maybe do it later instead of refactoring log_json to accept serde_json::Value (as mentioned in the comment)
GuillaumeLagrange
force-pushed
the
cod-681-take-provider-and-repo-information-from-cli-in-the-runner
branch
from
71ebc4f to
8118a42
Compare
adriencaccia
requested changes
Mar 28, 2025
art049
requested changes
Mar 28, 2025
GuillaumeLagrange
force-pushed
the
cod-681-take-provider-and-repo-information-from-cli-in-the-runner
branch
from
34c40da to
272d2d0
Compare
adriencaccia
approved these changes
Mar 31, 2025
GuillaumeLagrange
force-pushed
the
cod-681-take-provider-and-repo-information-from-cli-in-the-runner
branch
from
272d2d0 to
86abb1f
Compare
GuillaumeLagrange
force-pushed
the
cod-681-take-provider-and-repo-information-from-cli-in-the-runner
branch
from
86abb1f to
3a227ba
Compare
Contributor
Author
|
@art049 this is ready to be merged |
art049
approved these changes
Mar 31, 2025
GuillaumeLagrange
deleted the
cod-681-take-provider-and-repo-information-from-cli-in-the-runner
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
repositoryandproviderCLI arguments tocodspeed run--message-format=jsonsupport to get createdrunId(only structured log for now)