Cod 711 file name missing in codspeed rust flamegraph#93
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses missing debug symbols and integer overflow issues in benchmarks.
- Update fibonacci functions’ parameter and return types to u64 to prevent overflow.
- Rename the benchmark function from fibo_500 to fibo_50 to reflect the adjusted test value.
- Disable debug info stripping in the build script to preserve symbols in release builds.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/divan_compat/benches/basic_example.rs | Adjusts fibonacci function types and benchmark values to prevent overflow. |
| crates/cargo-codspeed/src/build.rs | Adds a rust flag to disable stripping of debug symbols in release builds. |
Comments suppressed due to low confidence (2)
crates/divan_compat/benches/basic_example.rs:17
- [nitpick] The function was renamed from fibo_500 to fibo_50, which may be confusing without context. Consider adding a comment or updating the function name to clearly reflect the new benchmark parameters.
fn fibo_50() -> u64 {
crates/cargo-codspeed/src/build.rs:125
- [nitpick] Disabling stripping of debug info via rust flags is a workaround for Cargo's release profile settings. Please verify that this flag does not conflict with other settings or introduces issues in different build environments.
rust_flags.push_str(" -C strip=none");
CodSpeed Instrumentation Performance ReportMerging #93 will degrade performances by 18.88%Comparing Summary
Benchmarks breakdown
|
CodSpeed Walltime Performance ReportMerging #93 will degrade performances by 53.23%Comparing Summary
Benchmarks breakdown
|
Cargo.tomland only through rust flags (this is a theory, have not dived into cargo code)