Merged
Conversation
CodSpeed Instrumentation Performance ReportMerging #84 will degrade performances by 24.48%Comparing Summary
Benchmarks breakdown
|
CodSpeed Walltime Performance ReportMerging #84 will degrade performances by 54.88%Comparing Summary
Benchmarks breakdown
|
|
This is great! thanks |
GuillaumeLagrange
requested changes
Mar 4, 2025
Contributor
GuillaumeLagrange
left a comment
There was a problem hiding this comment.
Lgtm, appart from the clippy lint that needs to be ignored for the CI to pass !
Same remark about commit signature
b6dbb75 to
f897280
Compare
Signed-off-by: not-matthias <matthias@codspeed.io>
f897280 to
e40765d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #82