Skip to content

feat: add support for all-features and no-default-features#83

Merged
not-matthias merged 2 commits intomainfrom
cod-303-add-support-for-build-all-features
Mar 4, 2025
Merged

feat: add support for all-features and no-default-features#83
not-matthias merged 2 commits intomainfrom
cod-303-add-support-for-build-all-features

Conversation

@not-matthias
Copy link
Member

@not-matthias not-matthias commented Mar 3, 2025

Added passthrough_flags to the BuildOptions which can be used to add more flags in the future if needed.

Closes #57

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 3, 2025

CodSpeed Instrumentation Performance Report

Merging #83 will not alter performance

Comparing cod-303-add-support-for-build-all-features (5517175) with main (6555f97)

Summary

✅ 152 untouched benchmarks

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 3, 2025

CodSpeed Walltime Performance Report

Merging #83 will degrade performances by 48.41%

Comparing cod-303-add-support-for-build-all-features (5517175) with main (6555f97)

Summary

❌ 11 regressions
✅ 87 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
recursive_memoized[BTreeMap<u64, u64>, 20] 1.8 µs 3.4 µs -48.41%
generate_combinations[8] 3.1 µs 3.3 µs -6.23%
generate_parentheses[4] 6.9 µs 7.6 µs -8.53%
generate_parentheses[5] 20.8 µs 22.9 µs -9.26%
generate_parentheses[6] 69.4 µs 72.1 µs -3.78%
graph_coloring[5] 4 µs 4.2 µs -3.45%
hamiltonian_cycle[5] 5 µs 5.3 µs -4.32%
hamiltonian_cycle[6] 5.8 µs 6 µs -3.22%
n_queens_solver[4] 1.6 µs 1.7 µs -5.56%
permutations[4] 2.3 µs 2.4 µs -3.96%
permutations[7] 795.7 µs 847.7 µs -6.14%

Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, good job! 🤗

@GuillaumeLagrange
Copy link
Contributor

Before merging, take the time to setup commit signatures, so that commits are marked as verified on github.

@GuillaumeLagrange GuillaumeLagrange self-requested a review March 4, 2025 10:08
Signed-off-by: not-matthias <matthias@codspeed.io>
Signed-off-by: not-matthias <matthias@codspeed.io>
@not-matthias not-matthias force-pushed the cod-303-add-support-for-build-all-features branch from f479ffb to 5517175 Compare March 4, 2025 10:37
@not-matthias not-matthias merged commit 5517175 into main Mar 4, 2025
6 checks passed
@not-matthias not-matthias deleted the cod-303-add-support-for-build-all-features branch March 4, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for build --all-features

2 participants