Make cargo-codspeed build targets to different directories between walltime and instrumented#68
Merged
GuillaumeLagrange merged 3 commits intomainfrom Feb 5, 2025
Conversation
GuillaumeLagrange
force-pushed
the
cod-533-make-cargo-codspeed-build-targets-to-different-directories
branch
from
70f171f to
f1ba23a
Compare
CodSpeed Walltime Performance ReportMerging #68 will not alter performanceComparing Summary
|
GuillaumeLagrange
force-pushed
the
cod-533-make-cargo-codspeed-build-targets-to-different-directories
branch
from
f1ba23a to
54eb1b4
Compare
CodSpeed Instrumentation Performance ReportMerging #68 will not alter performanceComparing Summary
|
GuillaumeLagrange
force-pushed
the
cod-533-make-cargo-codspeed-build-targets-to-different-directories
branch
from
ac99130 to
d208662
Compare
art049
requested changes
Feb 5, 2025
Member
art049
left a comment
art049
left a comment
There was a problem hiding this comment.
As we discussed it's not necessary to change the measurement mode to refs
Comment on lines
13
to
24
| impl AsRef<Path> for MeasurementMode { | ||
| fn as_ref(&self) -> &Path { | ||
| match self { | ||
| MeasurementMode::Walltime => Path::new("walltime"), | ||
| MeasurementMode::Instrumentation => Path::new("instrumentation"), | ||
| } | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
I think we should have a more generic serialization instead of this specific AsRef
art049
approved these changes
Feb 5, 2025
GuillaumeLagrange
force-pushed
the
cod-533-make-cargo-codspeed-build-targets-to-different-directories
branch
from
5cff374 to
6cf9e58
Compare
Contributor
Author
|
@art049 seems like we did not update the rules, and |
Member
Done :) |
GuillaumeLagrange
deleted the
cod-533-make-cargo-codspeed-build-targets-to-different-directories
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.