Add codspeed<>divan compat layer#65
Merged
GuillaumeLagrange merged 3 commits intomainfrom Feb 6, 2025
Merged
Conversation
CodSpeed Instrumentation Performance ReportMerging #65 will not alter performanceComparing Summary
|
215028a to
e2f2e7b
Compare
art049
reviewed
Jan 31, 2025
Member
art049
left a comment
There was a problem hiding this comment.
This is pretty cool overall and seem much more simple than for our other integration! let's go 💪
7802d9a to
c2cab59
Compare
art049
reviewed
Feb 5, 2025
Member
art049
left a comment
There was a problem hiding this comment.
We also need to run those new benches in the ci workflow before merging
682d7af to
8104c13
Compare
CodSpeed Walltime Performance ReportMerging #65 will not alter performanceComparing Summary
Benchmarks breakdown
|
8104c13 to
d9e5e62
Compare
02ab31a to
055d0f9
Compare
055d0f9 to
3d7a2a3
Compare
art049
approved these changes
Feb 6, 2025
Member
art049
left a comment
There was a problem hiding this comment.
🚀
As discused, can you undo the reformating of the doctest in the divan fork's doctests?
3d7a2a3 to
56ae65f
Compare
56ae65f to
d525802
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently implemented
#[divan::bench]divan::benchmacro.with_inputs()TODO before first release