fix: regression for handling rustflags from .cargo/config.toml#114
Merged
not-matthias merged 1 commit intomainfrom Jul 31, 2025
Merged
Conversation
CodSpeed Instrumentation Performance ReportMerging #114 will degrade performances by 15.89%Comparing Summary
Benchmarks breakdown
|
CodSpeed WallTime Performance ReportMerging #114 will degrade performances by 58.52%Comparing Summary
Benchmarks breakdown
|
21e72e1 to
a5b0ee0
Compare
a5b0ee0 to
b648598
Compare
art049
reviewed
Jul 29, 2025
…the .cargo/config.toml When using build.rustflags, it won't be merged because it has a lower precedence. See: https://doc.rust-lang.org/nightly/cargo/reference/config.html#buildrustflags
dd12b10 to
88f18b7
Compare
art049
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
target.<cfg>.rustflagsis set, ourbuild.rustflagsconfig value won't be used since it has a lower precedence (see: https://doc.rust-lang.org/nightly/cargo/reference/config.html#buildrustflags). We can solve this by usingtarget.cfg(all())but this will override anybuild.rustflagsvalues in the.cargo/config.toml.