fix: parsing walltime results in cargo codspeed breaks backwards#101
Merged
not-matthias merged 2 commits intomainfrom Jun 27, 2025
Merged
Conversation
CodSpeed Instrumentation Performance ReportMerging #101 will degrade performances by 24.48%Comparing Summary
Benchmarks breakdown
|
CodSpeed WallTime Performance ReportMerging #101 will degrade performances by 50%Comparing Summary
Benchmarks breakdown
|
adriencaccia
approved these changes
Jun 27, 2025
art049
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds upon #99
Changes in this PR:
WalltimeBenchmark/WalltimeResultslogic to codspeed crate. Also moved the logic for clearing / collecting the results in case we want to change the path later on (so we dont have to change it in cargo-codspeed as well)