Refactor for Identity-Aware Optimization#44
Merged
gitvishalshetty merged 8 commits intoJan 29, 2026
Conversation
- Added `coreason-identity` dependency. - Implemented `OptimizationClient` in `src/coreason_optimizer/core/client.py` with in-memory state and audit logging. - Added `StrategySelector` in `src/coreason_optimizer/strategies/selector.py` for identity-aware strategy selection. - Updated `Dataset` loader in `src/coreason_optimizer/data/loader.py` to enforce `UserContext` and log data access. - Updated CLI in `src/coreason_optimizer/main.py` to use `UserContext` and the new components. - Updated existing tests and added `tests/test_identity_enforcement.py` to ensure 100% coverage and compliance. Co-authored-by: gowthamrao <13936600+gowthamrao@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Added `coreason-identity` dependency. - Implemented `OptimizationClient` in `src/coreason_optimizer/core/client.py` with in-memory state and audit logging. - Added `StrategySelector` in `src/coreason_optimizer/strategies/selector.py` for identity-aware strategy selection. - Updated `Dataset` loader in `src/coreason_optimizer/data/loader.py` to enforce `UserContext` and log data access. - Updated CLI in `src/coreason_optimizer/main.py` to use `UserContext` and the new components. - Updated existing tests and added `tests/test_identity_enforcement.py` to ensure 100% coverage and compliance. - Fixed linting and type checking errors in tests. Co-authored-by: gowthamrao <13936600+gowthamrao@users.noreply.github.com>
Updated `pyproject.toml` and `src/coreason_optimizer/__init__.py` to version 0.2.0. Co-authored-by: gowthamrao <13936600+gowthamrao@users.noreply.github.com>
- Updated `pyproject.toml` and `src/coreason_optimizer/__init__.py` to version 0.2.0. - Fixed linting error in `src/coreason_optimizer/main.py` (unused import). Co-authored-by: gowthamrao <13936600+gowthamrao@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
- Updated `tests/test_logger_coverage.py` to correctly test the directory creation logic in `src/coreason_optimizer/utils/logger.py` by reloading the module after clearing the `logs` directory. - Achieved 100% test coverage. Co-authored-by: gowthamrao <13936600+gowthamrao@users.noreply.github.com>
- Updated `tests/test_logger_coverage.py` to correctly test the directory creation logic in `src/coreason_optimizer/utils/logger.py` by reloading the module after clearing the `logs` directory. - Fixed linting error in `tests/test_logger_coverage.py` (unused imports). - Achieved 100% test coverage. Co-authored-by: gowthamrao <13936600+gowthamrao@users.noreply.github.com>
- Updated `tests/test_logger_coverage.py` to correctly test the directory creation logic in `src/coreason_optimizer/utils/logger.py` by reloading the module after clearing the `logs` directory. - Fixed linting error in `tests/test_logger_coverage.py` (unused imports). - Fixed `AttributeError` in test by using `logger.logger.remove()` to properly access the underlying loguru object. - Achieved 100% test coverage. Co-authored-by: gowthamrao <13936600+gowthamrao@users.noreply.github.com>
- Updated `tests/test_logger_coverage.py` to correctly test the directory creation logic in `src/coreason_optimizer/utils/logger.py` by reloading the module after clearing the `logs` directory. - Fixed linting error in `tests/test_logger_coverage.py` (unused imports). - Fixed `AttributeError` and Windows `PermissionError` in test by using `logger.logger.remove()` to properly access the underlying loguru object and release file handles. - Achieved 100% test coverage.
gitvishalshetty
deleted the
identity-aware-optimization-9012995880739134422
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the
coreason-optimizerpackage to implement "Identity-Aware Optimization" by mandatingUserContextfor key operations.Key changes:
coreason-identity.Dataset.from_csvandfrom_jsonlto requireUserContextand audit data access.main.pyto establish a system identity context and propagate it through the stack.Note:
UserContext.user_idis treated as a string based on the installed library version (0.4.2), deviating slightly from the prompt'sget_secret_value()instruction which was incompatible with the library. Audit logs capture the user ID directly.PR created automatically by Jules for task 9012995880739134422 started by @gowthamrao