Refactor: Migrate to coreason-manifest 0.7.0 (Shared Kernel)#105
Closed
gowthamrao wants to merge 4 commits into
Closed
Refactor: Migrate to coreason-manifest 0.7.0 (Shared Kernel)#105gowthamrao wants to merge 4 commits into
gowthamrao wants to merge 4 commits into
Conversation
- Updated `pyproject.toml` dependency. - Updated `src/coreason_maco/core/manifest.py` to import strictly from `coreason-manifest`. - Refactored `src/coreason_maco/events/protocol.py` to remove legacy aliases (`*Payload`) and align naming with kernel conventions. Note: Local event models are retained as they are currently missing from the `coreason-manifest` 0.7.0 library, but code is prepared for future switch. - Refactored `runner.py`, `handlers.py`, and `topology.py` to use updated models and naming. - Refactored tests to use updated imports and model names. - Cleaned up imports across test suite. Co-authored-by: gowthamrao <13936600+gowthamrao@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Updated `pyproject.toml` dependency. - Updated `src/coreason_maco/core/manifest.py` to import strictly from `coreason-manifest`. - Refactored `src/coreason_maco/events/protocol.py` to remove legacy aliases (`*Payload`) and align naming with kernel conventions. Note: Local event models are retained as they are currently missing from the `coreason-manifest` 0.7.0 library, but code is prepared for future switch. - Refactored `runner.py`, `handlers.py`, and `topology.py` to use updated models and naming. - Refactored tests to use updated imports and model names. - Cleaned up imports across test suite. - Fixed linting issues. Co-authored-by: gowthamrao <13936600+gowthamrao@users.noreply.github.com>
- Updated `pyproject.toml` dependency. - Updated `src/coreason_maco/core/manifest.py` to import strictly from `coreason-manifest`. - Refactored `src/coreason_maco/events/protocol.py` to remove legacy aliases (`*Payload`) and align naming with kernel conventions. Note: Local event models are retained as they are currently missing from the `coreason-manifest` 0.7.0 library, but code is prepared for future switch. - Refactored `runner.py`, `handlers.py`, and `topology.py` to use updated models and naming. - Refactored tests to use updated imports and model names. - Cleaned up imports across test suite. - Fixed linting issues (imports, formatting) as per ruff checks. Co-authored-by: gowthamrao <13936600+gowthamrao@users.noreply.github.com>
- Updated `pyproject.toml` dependency. - Updated `src/coreason_maco/core/manifest.py` to import strictly from `coreason-manifest`. - Refactored `src/coreason_maco/events/protocol.py` to remove legacy aliases (`*Payload`) and align naming with kernel conventions. Note: Local event models are retained as they are currently missing from the `coreason-manifest` 0.7.0 library, but code is prepared for future switch. - Refactored `runner.py`, `handlers.py`, and `topology.py` to use updated models and naming. - Refactored tests to use updated imports and model names. - Cleaned up imports across test suite. - Fixed linting issues (imports, formatting) as per ruff checks. - Regenerated `poetry.lock`. Co-authored-by: gowthamrao <13936600+gowthamrao@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated
coreason-macoto usecoreason-manifestv0.7.0.pyproject.tomldependency.src/coreason_maco/core/manifest.pyto import strictly fromcoreason-manifest.src/coreason_maco/events/protocol.pyto remove legacy aliases (*Payload) and align naming with kernel conventions. Note: Local event models are retained as they are currently missing from thecoreason-manifest0.7.0 library, but code is prepared for future switch.runner.py,handlers.py, andtopology.pyto use updated models and naming.PR created automatically by Jules for task 4929844531358961225 started by @gowthamrao