Refactor Builder to use Shared Kernel (coreason-manifest)#18
Conversation
- Updated `pyproject.toml` to require `coreason-manifest = "^0.7.0"`. - Refactored `src/coreason_maco_builder/core/compiler/manifest.py` to be a facade exporting types from `coreason-manifest`. - Updated `src/coreason_maco_builder/core/weaver/assembler.py` to implement `assemble` method using kernel types. - Updated tests to verify assembly logic and manifest exports. - Ensured strict separation between Builder domain and Kernel artifacts. Co-authored-by: gowthamrao <13936600+gowthamrao@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Removed unused `pytest` import. - Added return type annotation to `test_manifest_facade_exports`. Co-authored-by: gowthamrao <13936600+gowthamrao@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…e Cases - Updated `pyproject.toml` to require `coreason-manifest = "^0.7.0"`. - Refactored `src/coreason_maco_builder/core/compiler/manifest.py` to be a facade exporting types from `coreason-manifest`. - Updated `src/coreason_maco_builder/core/weaver/assembler.py` to implement `assemble` method using kernel types. - Added `tests/core/weaver/test_assembler_edge_cases.py` to test empty topology and validation errors. - Updated `README.md` to document the architectural dependency on the shared kernel. - Fixed lint/type errors in tests. Co-authored-by: gowthamrao <13936600+gowthamrao@users.noreply.github.com>
- Applied `ruff format` to fix CI failure. Co-authored-by: gowthamrao <13936600+gowthamrao@users.noreply.github.com>
gowthamrao
deleted the
refactor/manifest-integration-13045588563407015823
branch
* Refactor Builder to use Shared Kernel (coreason-manifest) - Updated `pyproject.toml` to require `coreason-manifest = "^0.7.0"`. - Refactored `src/coreason_maco_builder/core/compiler/manifest.py` to be a facade exporting types from `coreason-manifest`. - Updated `src/coreason_maco_builder/core/weaver/assembler.py` to implement `assemble` method using kernel types. - Updated tests to verify assembly logic and manifest exports. - Ensured strict separation between Builder domain and Kernel artifacts. 1ed7b35
1 participant
This PR refactors the
coreason-maco-builderto eliminate redundant local schema definitions forRecipeManifest,Node, etc., and instead consumes them from the Shared Kernel (coreason-manifestv0.7.0).Key changes:
coreason-manifestto^0.7.0.manifest.pynow re-exports classes fromcoreason_manifest, removing local logic.Weaverclass now includes anassemblemethod that converts a fully resolvedRecipeDraftinto aRecipeManifestcompliant with the kernel.PR created automatically by Jules for task 13045588563407015823 started by @gowthamrao